You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Henry Zongaro (JIRA)" <xa...@xml.apache.org> on 2006/10/16 16:07:35 UTC
[jira] Commented: (XALANJ-2209) [PATCH] invalid code tries to
compare unrelated objects
[ http://issues.apache.org/jira/browse/XALANJ-2209?page=comments#action_12442607 ]
Henry Zongaro commented on XALANJ-2209:
---------------------------------------
I have reviewed the attached patch.[1] Although the change is correct, the code that it guards is redundant, and the entire check and error should be removed instead. Just a few lines above in AttributeSet.parseContents, there is a check of whether the "name" attribute contains a valid QName.
[1] http://issues.apache.org/jira/secure/attachment/12314816/fix_equals.diff
> [PATCH] invalid code tries to compare unrelated objects
> -------------------------------------------------------
>
> Key: XALANJ-2209
> URL: http://issues.apache.org/jira/browse/XALANJ-2209
> Project: XalanJ2
> Issue Type: Improvement
> Components: XSLTC
> Affects Versions: Latest Development Code
> Reporter: Dave Brosius
> Priority: Minor
> Attachments: fix_equals.diff
>
>
> A QName is attempted to be .equals with a string. This will always be false. compare the stringrep instead
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org