You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/21 14:08:34 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2582: Build against arrow-ballista in CI
andygrove opened a new pull request, #2582:
URL: https://github.com/apache/arrow-datafusion/pull/2582
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of https://github.com/apache/arrow-datafusion/issues/2502
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
We need to build against `arrow-ballista` to detect breaking changes
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- [x] Remove ballista from workspace
- [x] Add script to pull arrow-ballista, change dependency paths, and build
- [ ] Add GitHub action
- [ ] Add mechanism for building against specific arrow-ballista PR/branch
- [ ] Update contributing guide
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Yes, CI and process changes
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2582: Build against `arrow-ballista` in CI & remove ballista code from this repo
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2582:
URL: https://github.com/apache/arrow-datafusion/pull/2582#issuecomment-1134556131
> I do wonder if it might be less friction to do what we do with arrow-rs, have ballista track a released DataFusion version and update it as part of the release process for DataFusion.
I think this is the ideal outcome, however it takes a non trivial effort now to release arrow bi-weekly to keep the code flowing, and and we haven't yet been able to do it with DataFusion. Until we get experience and confidence we'll have regular DataFusion releases, I would recommend we keep developing Ballista on the tip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #2582: Build against `arrow-ballista` in CI & remove ballista code from this repo
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2582:
URL: https://github.com/apache/arrow-datafusion/pull/2582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2582: Build against `arrow-ballista` in CI & remove ballista code from this repo
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #2582:
URL: https://github.com/apache/arrow-datafusion/pull/2582#discussion_r878875387
##########
dev/build-arrow-ballista.sh:
##########
@@ -15,8 +17,18 @@
# specific language governing permissions and limitations
# under the License.
-# the default configuration location is "/etc/ballista/scheduler.toml"
-# if you include a specifc conf file using "--config-file = my_config_file.toml"
-# then that file will override environment variables, but not command line arguments
-namespace = "my_name_space"
-bind_host = "1.2.3.4"
\ No newline at end of file
+set -e
+
+# delete any previously cloned arrow-ballista repo
+rm -rf arrow-ballista 2>/dev/null
+
+# clone the repo
+# TODO make repo/branch configurable
+git clone https://github.com/apache/arrow-ballista
Review Comment:
That's a good question and I'm really not sure what the best approach is. Perhaps we wait until we hit this situation and then we can pin to the commit prior to the breaking change.
DataFusion no longer depends on Ballista so I am not sure what kind of change would cause us to deal with this situation but I am sure it is possible somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2582: Build against `arrow-ballista` in CI & remove ballista code from this repo
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2582:
URL: https://github.com/apache/arrow-datafusion/pull/2582#issuecomment-1133905199
> I think this is a good step forward, I have a fair few breaking changes in flight so I guess we'll get to exercise the process for them soon sweat_smile
>
> Edit: I do wonder if it might be less friction to do what we do with arrow-rs, have ballista track a released DataFusion version and update it as part of the release process for DataFusion. Whilst this does result in a delay getting new features, keeping this delay low is probably of interest to more than just Ballista...
Thanks for the review @tustvold. I also have plenty of breaking API changes planned so this will definitely get tested soon and I am sure we will either iterate on this process or abandon it in favor of the approach you suggest. With more frequent DataFusion releases and the current level of activity in Ballisata, I think that this would likely be fine.
I suggest we try this approach out over the next week or two and see how it goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2582: Build against `arrow-ballista` in CI & remove ballista code from this repo
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2582:
URL: https://github.com/apache/arrow-datafusion/pull/2582#discussion_r878834445
##########
dev/build-arrow-ballista.sh:
##########
@@ -15,8 +17,18 @@
# specific language governing permissions and limitations
# under the License.
-# the default configuration location is "/etc/ballista/scheduler.toml"
-# if you include a specifc conf file using "--config-file = my_config_file.toml"
-# then that file will override environment variables, but not command line arguments
-namespace = "my_name_space"
-bind_host = "1.2.3.4"
\ No newline at end of file
+set -e
+
+# delete any previously cloned arrow-ballista repo
+rm -rf arrow-ballista 2>/dev/null
+
+# clone the repo
+# TODO make repo/branch configurable
+git clone https://github.com/apache/arrow-ballista
Review Comment:
Do we want to always pin this so that Ballista changes can't side-effect on unrelated DataFusion PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2582: Build against `arrow-ballista` in CI
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2582:
URL: https://github.com/apache/arrow-datafusion/pull/2582#issuecomment-1133652171
@liukun4515 @yahoNanJing @mingmwang @thinkharderdev @gaojun2048 @realno @thinkharderdev @matthewmturner @yjshen @alamb @tustvold fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org