You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/26 03:43:05 UTC
[GitHub] [skywalking] codecov-io edited a comment on issue #4570:
[WIP][Inventory Design Change] Remove endpoint register and endpoint
inventory
codecov-io edited a comment on issue #4570: [WIP][Inventory Design Change] Remove endpoint register and endpoint inventory
URL: https://github.com/apache/skywalking/pull/4570#issuecomment-604210849
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=h1) Report
> Merging [#4570](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/569baf3236226b17c3b40e376e5681b5623abf38&el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `1.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4570 +/- ##
==========================================
+ Coverage 25.99% 26.16% +0.17%
==========================================
Files 1250 1246 -4
Lines 29071 28888 -183
Branches 3990 3939 -51
==========================================
+ Hits 7556 7559 +3
+ Misses 20822 20636 -186
Partials 693 693
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../oap/server/exporter/provider/MetricFormatter.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL01ldHJpY0Zvcm1hdHRlci5qYXZh) | `16.66% <0.00%> (+1.28%)` | :arrow_up: |
| [...r/exporter/provider/grpc/GRPCExporterProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyUHJvdmlkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `4.08% <ø> (+0.16%)` | :arrow_up: |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../skywalking/oap/server/core/alarm/AlarmRecord.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1SZWNvcmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ing/oap/server/core/alarm/EndpointMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vRW5kcG9pbnRNZXRhSW5BbGFybS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../skywalking/oap/server/core/alarm/MetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../server/core/alarm/ServiceInstanceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZUluc3RhbmNlTWV0YUluQWxhcm0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...king/oap/server/core/alarm/ServiceMetaInAlarm.java](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vU2VydmljZU1ldGFJbkFsYXJtLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [78 more](https://codecov.io/gh/apache/skywalking/pull/4570/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=footer). Last update [569baf3...ecbdefd](https://codecov.io/gh/apache/skywalking/pull/4570?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services