You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jinho Kim <jh...@apache.org> on 2014/04/29 06:59:27 UTC
Review Request 20828: TAJO-617: Rename BIN/tajo_dump BIN/tajo-dump
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20828/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-617
https://issues.apache.org/jira/browse/TAJO-617
Repository: tajo
Description
-------
All commands in bin directory uses dash for separator. But tajo_dump command uses underscore. I think tajo-dump is proper name.
Diffs
-----
tajo-dist/src/main/bin/tajo_dump
Diff: https://reviews.apache.org/r/20828/diff/
Testing
-------
Thanks,
Jinho Kim
Re: Review Request 20828: TAJO-617: Rename BIN/tajo_dump BIN/tajo-dump
Posted by Hyunsik Choi <hy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20828/#review41746
-----------------------------------------------------------
Ship it!
+1 ship it!
- Hyunsik Choi
On April 29, 2014, 2:08 p.m., Jinho Kim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20828/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 2:08 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-617
> https://issues.apache.org/jira/browse/TAJO-617
>
>
> Repository: tajo
>
>
> Description
> -------
>
> All commands in bin directory uses dash for separator. But tajo_dump command uses underscore. I think tajo-dump is proper name.
>
>
> Diffs
> -----
>
> tajo-client/src/main/java/org/apache/tajo/client/TajoDump.java 60b1a7e7cbea0c924e7880ae91ba15e6837e7b62
> tajo-dist/src/main/bin/tajo_dump
> tajo-docs/src/main/sphinx/backup_and_restore/catalog.rst b922c62c0370eba166dde0f5e365ebf095ef4c5a
>
> Diff: https://reviews.apache.org/r/20828/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jinho Kim
>
>
Re: Review Request 20828: TAJO-617: Rename BIN/tajo_dump BIN/tajo-dump
Posted by Jinho Kim <jh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20828/
-----------------------------------------------------------
(Updated April 29, 2014, 5:08 a.m.)
Review request for Tajo.
Changes
-------
missing documents
Bugs: TAJO-617
https://issues.apache.org/jira/browse/TAJO-617
Repository: tajo
Description
-------
All commands in bin directory uses dash for separator. But tajo_dump command uses underscore. I think tajo-dump is proper name.
Diffs (updated)
-----
tajo-client/src/main/java/org/apache/tajo/client/TajoDump.java 60b1a7e7cbea0c924e7880ae91ba15e6837e7b62
tajo-dist/src/main/bin/tajo_dump
tajo-docs/src/main/sphinx/backup_and_restore/catalog.rst b922c62c0370eba166dde0f5e365ebf095ef4c5a
Diff: https://reviews.apache.org/r/20828/diff/
Testing
-------
Thanks,
Jinho Kim