You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Jirsa (JIRA)" <ji...@apache.org> on 2015/10/20 07:36:27 UTC

[jira] [Created] (CASSANDRA-10555) ReadCommandTest should truncate between test cases

Jeff Jirsa created CASSANDRA-10555:
--------------------------------------

             Summary: ReadCommandTest should truncate between test cases 
                 Key: CASSANDRA-10555
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10555
             Project: Cassandra
          Issue Type: Bug
            Reporter: Jeff Jirsa
            Priority: Minor


ReadCommandTest writes to the same CF in multiple unit tests, and then counts the results in a partition. This can lead to tests failing in some circumstances:

{noformat}
    [junit] Testcase: testSinglePartitionNamesAbort(org.apache.cassandra.db.ReadCommandTest):	FAILED
    [junit] expected:<2> but was:<1>
    [junit] junit.framework.AssertionFailedError: expected:<2> but was:<1>
    [junit] 	at org.apache.cassandra.db.ReadCommandTest.testSinglePartitionNamesAbort(ReadCommandTest.java:140)
    [junit] 
    [junit] 
    [junit] Testcase: testSinglePartitionSliceAbort(org.apache.cassandra.db.ReadCommandTest):	FAILED
    [junit] expected:<2> but was:<3>
    [junit] junit.framework.AssertionFailedError: expected:<2> but was:<3>
    [junit] 	at org.apache.cassandra.db.ReadCommandTest.testSinglePartitionSliceAbort(ReadCommandTest.java:111)
{noformat}

This can be fixed trivially by truncating the CF at the beginning of {{testSinglePartitionSliceAbort}} and {{testSinglePartitionNamesAbort}} 

Also, once the truncate is in place, a potential typo is exposed in {{testSinglePartitionNamesAbort}}, where the partition is written with clustering column {{cc}} and {{cdd}}, but the read command reads {{cc}} and {{dd}} 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)