You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/09 18:14:16 UTC

[GitHub] [kafka] cmccabe commented on a diff in pull request #12833: KAFKA-14370: Properly close ImageWriter objects

cmccabe commented on code in PR #12833:
URL: https://github.com/apache/kafka/pull/12833#discussion_r1018269186


##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -398,8 +398,11 @@ class BrokerMetadataListener(
         build()
       try {
         _image.write(writer, options)
-      } finally {
-        writer.close()
+        writer.close(true)

Review Comment:
   Yes, you are right that we're already calling `ImageWriter.close(true)` in `MetadataImage.write`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org