You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "David Garcia (JIRA)" <ji...@apache.org> on 2006/09/13 13:28:25 UTC

[jira] Created: (PLUTO-258) Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)

Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)
--------------------------------------------------------------------------------

                 Key: PLUTO-258
                 URL: http://issues.apache.org/jira/browse/PLUTO-258
             Project: Pluto
          Issue Type: Bug
          Components: portlet container taglibs
    Affects Versions: 1.1.0-beta1
            Reporter: David Garcia
            Priority: Minor


This bug was fixed for 1.0.1 (see PLUTO-97) but remains unfixed in 1.1.

The affected classes are BasicURLTag (where TEI is defined), RenderURLTag and ActionURLTag in package org.apache.pluto.tags.
The solution implemented in 1.0.1 was to always do new PortletMode(portletMode) or new WindowState(windowState) instead of looking it up from TEI.portletModes or TEI.definedWindowStates.
If that solution is ok for 1.1 I can submit a patch.

Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (PLUTO-258) Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)

Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-258?page=all ]

David DeWolf resolved PLUTO-258.
--------------------------------

    Resolution: Fixed

Thanks! I patched it a little bit differently, but used the same concept.  The basic differnence is that I moved a lot of the duplication up to the basic tag and still used the static modes if they are available.

> Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)
> --------------------------------------------------------------------------------
>
>                 Key: PLUTO-258
>                 URL: http://issues.apache.org/jira/browse/PLUTO-258
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container taglibs
>    Affects Versions: 1.1.0-beta1
>            Reporter: David Garcia
>         Assigned To: David DeWolf
>            Priority: Minor
>             Fix For: 1.1.0
>
>         Attachments: URLTag_patch.diff
>
>
> This bug was fixed for 1.0.1 (see PLUTO-97) but remains unfixed in 1.1.
> The affected classes are BasicURLTag (where TEI is defined), RenderURLTag and ActionURLTag in package org.apache.pluto.tags.
> The solution implemented in 1.0.1 was to always do new PortletMode(portletMode) or new WindowState(windowState) instead of looking it up from TEI.portletModes or TEI.definedWindowStates.
> If that solution is ok for 1.1 I can submit a patch.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (PLUTO-258) Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/PLUTO-258?page=comments#action_12448702 ] 
            
Craig Doremus commented on PLUTO-258:
-------------------------------------

David, Please submit your patch. We will take a look at it and commit. Thanks.

> Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)
> --------------------------------------------------------------------------------
>
>                 Key: PLUTO-258
>                 URL: http://issues.apache.org/jira/browse/PLUTO-258
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container taglibs
>    Affects Versions: 1.1.0-beta1
>            Reporter: David Garcia
>            Priority: Minor
>
> This bug was fixed for 1.0.1 (see PLUTO-97) but remains unfixed in 1.1.
> The affected classes are BasicURLTag (where TEI is defined), RenderURLTag and ActionURLTag in package org.apache.pluto.tags.
> The solution implemented in 1.0.1 was to always do new PortletMode(portletMode) or new WindowState(windowState) instead of looking it up from TEI.portletModes or TEI.definedWindowStates.
> If that solution is ok for 1.1 I can submit a patch.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (PLUTO-258) Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)

Posted by "David Garcia (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-258?page=all ]

David Garcia updated PLUTO-258:
-------------------------------

    Attachment: URLTag_patch.diff

Hi,

Here“s the patch for BasicURLTag, ActionURLTag and RenderURLTag in package org.apache.pluto.tags.
It has been working OK for us since I reported this issue.

Thanks.


> Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)
> --------------------------------------------------------------------------------
>
>                 Key: PLUTO-258
>                 URL: http://issues.apache.org/jira/browse/PLUTO-258
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container taglibs
>    Affects Versions: 1.1.0-beta1
>            Reporter: David Garcia
>            Priority: Minor
>         Attachments: URLTag_patch.diff
>
>
> This bug was fixed for 1.0.1 (see PLUTO-97) but remains unfixed in 1.1.
> The affected classes are BasicURLTag (where TEI is defined), RenderURLTag and ActionURLTag in package org.apache.pluto.tags.
> The solution implemented in 1.0.1 was to always do new PortletMode(portletMode) or new WindowState(windowState) instead of looking it up from TEI.portletModes or TEI.definedWindowStates.
> If that solution is ok for 1.1 I can submit a patch.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Assigned: (PLUTO-258) Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)

Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-258?page=all ]

David DeWolf reassigned PLUTO-258:
----------------------------------

    Assignee: David DeWolf

> Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)
> --------------------------------------------------------------------------------
>
>                 Key: PLUTO-258
>                 URL: http://issues.apache.org/jira/browse/PLUTO-258
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container taglibs
>    Affects Versions: 1.1.0-beta1
>            Reporter: David Garcia
>         Assigned To: David DeWolf
>            Priority: Minor
>             Fix For: 1.1.0
>
>         Attachments: URLTag_patch.diff
>
>
> This bug was fixed for 1.0.1 (see PLUTO-97) but remains unfixed in 1.1.
> The affected classes are BasicURLTag (where TEI is defined), RenderURLTag and ActionURLTag in package org.apache.pluto.tags.
> The solution implemented in 1.0.1 was to always do new PortletMode(portletMode) or new WindowState(windowState) instead of looking it up from TEI.portletModes or TEI.definedWindowStates.
> If that solution is ok for 1.1 I can submit a patch.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (PLUTO-258) Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)

Posted by "David DeWolf (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-258?page=all ]

David DeWolf updated PLUTO-258:
-------------------------------

    Fix Version/s: 1.1.0

> Custom WindowStates and PortletModes do not work with tag library (in Pluto 1.1)
> --------------------------------------------------------------------------------
>
>                 Key: PLUTO-258
>                 URL: http://issues.apache.org/jira/browse/PLUTO-258
>             Project: Pluto
>          Issue Type: Bug
>          Components: portlet container taglibs
>    Affects Versions: 1.1.0-beta1
>            Reporter: David Garcia
>            Priority: Minor
>             Fix For: 1.1.0
>
>         Attachments: URLTag_patch.diff
>
>
> This bug was fixed for 1.0.1 (see PLUTO-97) but remains unfixed in 1.1.
> The affected classes are BasicURLTag (where TEI is defined), RenderURLTag and ActionURLTag in package org.apache.pluto.tags.
> The solution implemented in 1.0.1 was to always do new PortletMode(portletMode) or new WindowState(windowState) instead of looking it up from TEI.portletModes or TEI.definedWindowStates.
> If that solution is ok for 1.1 I can submit a patch.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira