You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2009/04/16 03:04:14 UTC
[jira] Created: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
------------------------------------------------------------------------------------
Key: HADOOP-5688
URL: https://issues.apache.org/jira/browse/HADOOP-5688
Project: Hadoop Core
Issue Type: Bug
Components: fs
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701013#action_12701013 ]
Chris Douglas commented on HADOOP-5688:
---------------------------------------
+1
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5688_20090415.patch
>
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702078#action_12702078 ]
Hudson commented on HADOOP-5688:
--------------------------------
Integrated in Hadoop-trunk #815 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/815/])
. Fix HftpFileSystem checksum path construction. Contributed by Tsz Wo (Nicholas) Sze
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.1
>
> Attachments: 5688_20090415.patch
>
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5688:
-------------------------------------------
Status: Patch Available (was: Open)
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5688_20090415.patch
>
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5688:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.20.1
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed this. Thanks, Nicholas
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.20.1
>
> Attachments: 5688_20090415.patch
>
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-5688)
HftpFileSystem.getChecksum(..) does not work for the paths with scheme and
authority
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699474#action_12699474 ]
Tsz Wo (Nicholas), SZE edited comment on HADOOP-5688 at 4/15/09 8:27 PM:
-------------------------------------------------------------------------
The problem is that HftpFileSystem does not construct the url correctly if the path contents scheme and authority information. For example
{code}
Path p = new Path("hftp://localhost:2750/foo");
FileSystem hftpfs = p.getFileSystem(conf);
FileChecksum cs = hftpfs.getFileChecksum(p);
/*
The url constructed above will be
http://localhost:2750/fileChecksumhftp://localhost:2750/filechecksum/foo?ugi=...
However, the correct url is
http://localhost:2750/fileChecksum/foo?ugi=...
*/
{code}
was (Author: szetszwo):
The problem is that HftpFileSystem does not construct the url correctly if the path contents scheme and authority information. For example
{code}
Path p = new Path("hftp://localhost:2750/filechecksum/foo");
FileSystem hftpfs = p.getFileSystem(conf);
FileChecksum cs = hftpfs.getFileChecksum(p);
/*
The url constructed above will be
http://localhost:2750/fileChecksumhftp://localhost:2750/filechecksum/foo?ugi=...
The correct url is
http://localhost:2750/fileChecksum/foo?ugi=...
*/
{code}
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5688_20090415.patch
>
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5688:
-------------------------------------------
Attachment: 5688_20090415.patch
5688_20090415.patch: fix the file checksum url.
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5688_20090415.patch
>
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700918#action_12700918 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5688:
------------------------------------------------
{noformat}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{noformat}
Running unit tests locally.
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5688_20090415.patch
>
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5688:
-------------------------------------------
Component/s: (was: fs)
dfs
The problem is that HftpFileSystem does not construct the url correctly if the path contents scheme and authority information. For example
{code}
Path p = new Path("hftp://localhost:2750/filechecksum/foo");
FileSystem hftpfs = p.getFileSystem(conf);
FileChecksum cs = hftpfs.getFileChecksum(p);
/*
The url constructed above will be
http://localhost:2750/fileChecksumhftp://localhost:2750/filechecksum/foo?ugi=...
The correct url is
http://localhost:2750/fileChecksum/foo?ugi=...
*/
{code}
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5688) HftpFileSystem.getChecksum(..) does
not work for the paths with scheme and authority
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700999#action_12700999 ]
Hadoop QA commented on HADOOP-5688:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405604/5688_20090415.patch
against trunk revision 766670.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/214/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/214/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/214/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/214/console
This message is automatically generated.
> HftpFileSystem.getChecksum(..) does not work for the paths with scheme and authority
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5688
> URL: https://issues.apache.org/jira/browse/HADOOP-5688
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5688_20090415.patch
>
>
> If a path with scheme and authority information (e.g. hftp://hostname:50070/foo.txt) is passed to HftpFileSystem.getChecksum(..), it won't return the correct file checksum.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.