You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2023/06/06 10:58:38 UTC
[Impala-ASF-CR] IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20015
Change subject: IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
......................................................................
IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
Iceberg LOAD DATA creates a temporary table during execution. To help
Apache Atlas identify these tables properly 'TEMPORARY' table property
was added to the tmp table's CREATE statement in this commit.
Testing:
- Manually checked the presence of the table property
Change-Id: Ic0985950672a461894e85cdb3387936d10769690
---
M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java
M fe/src/main/java/org/apache/impala/analysis/QueryStringBuilder.java
2 files changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/20015/1
--
To view, visit http://gerrit.cloudera.org:8080/20015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0985950672a461894e85cdb3387936d10769690
Gerrit-Change-Number: 20015
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20015 )
Change subject: IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9377/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/20015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0985950672a461894e85cdb3387936d10769690
Gerrit-Change-Number: 20015
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Jun 2023 12:44:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20015 )
Change subject: IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
......................................................................
Patch Set 1: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/20015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0985950672a461894e85cdb3387936d10769690
Gerrit-Change-Number: 20015
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 09:05:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20015 )
Change subject: IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0985950672a461894e85cdb3387936d10769690
Gerrit-Change-Number: 20015
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Jun 2023 18:00:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20015 )
Change subject: IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
......................................................................
IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
Iceberg LOAD DATA creates a temporary table during execution. To help
Apache Atlas identify these tables properly 'TEMPORARY' table property
was added to the tmp table's CREATE statement in this commit.
Testing:
- Manually checked the presence of the table property
Change-Id: Ic0985950672a461894e85cdb3387936d10769690
Reviewed-on: http://gerrit.cloudera.org:8080/20015
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java
M fe/src/main/java/org/apache/impala/analysis/QueryStringBuilder.java
2 files changed, 23 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Zoltan Borok-Nagy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0985950672a461894e85cdb3387936d10769690
Gerrit-Change-Number: 20015
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20015 )
Change subject: IMPALA-12186: Add table property to Iceberg LOAD DATA tmp tables
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13207/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0985950672a461894e85cdb3387936d10769690
Gerrit-Change-Number: 20015
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Jun 2023 11:21:27 +0000
Gerrit-HasComments: No