[jira] Commented: (OFBIZ-1086) Show prices incl. VAT in shoppingcart Total and miniproductsummary

["Anne Jessel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588924#action_12588924 ] 

Anne Jessel commented on OFBIZ-1086:
------------------------------------

I solved the problem with VAT (GST in my case) not being displayed in the Last Products Minibox by altering miniproductsummary.bsh in the way quoted in Christian's comment above (before I checked Jira!). The addition of the checkIncludeVat=Y parameter seemed to be the obvious and correct solution, as the value is then passed to, and used by, the calculateProductPrice service. I do not see the behaviour described by Christian. I have not been able to find anything that saves the result of the calculateProductPrice service call in miniproductsummary.bsh to anywhere that might be used in a subsequent calculation. As best I can see, the result is used only for display.

Also, Christian states the solution works without the checkIncludeVat=Y change (that is,no change to the existing buggy miniproductsummary.bsh), but it certainly doesn't for me, and I don't see from the code how it could ever work.

Could the confusion be because the patch attached to this issue attempts to solve several separate problems (Mini shopping cart, Last Products minibox,...), and the problems Christian discovered with the patch were unrelated to the miniproductsummary.bsh fix for the Last Products Minibox? If so, I can submit a patch that includes only that change. If not, could someone please explain what the problem is with this change to miniproductsummary.bsh so I can try to work out a different solution?

> Show prices incl. VAT in shoppingcart Total and miniproductsummary
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-1086
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1086
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Thomas Herzog
>             Fix For: SVN trunk
>
>         Attachments: carttotal_miniproductsummary_prices__incl_VAT.diff
>
>
> In current implementation of VAT displays a mixture of incl. and excl. prices in some ecommerce screens. This patch shows prices incl. VAT for Mini Shopping Cart Total, Micro Shopping Cart Total (displayed in the Header), Last Products Minibox and Quick Reorder... Minibox.
> It also solves issuses left open in OFBIZ-113.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.