You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/07 12:25:21 UTC
[GitHub] [spark] KarlManong opened a new pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
KarlManong opened a new pull request #32080:
URL: https://github.com/apache/spark/pull/32080
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
exit when exception happens
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
spark-submit didn't handle all exceptions that will leave threads running for 5 minutes
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
sorry, I have no idea how to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32080:
URL: https://github.com/apache/spark/pull/32080#issuecomment-815123667
BTW, this doesn't look like SPARK-34674 because the case in SPARK-34674 ends without throwing `Exception`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32080:
URL: https://github.com/apache/spark/pull/32080#issuecomment-815123667
BTW, this doesn't look like SPARK-34674 because the case in SPARK-34674 ends without throwing `Exception`. I'd like to recommend to have a separate JIRA issue if your case is considering unhandled `Exception` from your apps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32080:
URL: https://github.com/apache/spark/pull/32080#issuecomment-814872280
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32080:
URL: https://github.com/apache/spark/pull/32080#discussion_r608884309
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1031,6 +1031,8 @@ object SparkSubmit extends CommandLineUtils with Logging {
} catch {
case e: SparkUserAppException =>
exitFn(e.exitCode)
+ case _: Throwable =>
Review comment:
Please remove the extra space at the end of this line.
```
[error] /home/runner/work/spark/spark/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:1034:30: Whitespace at end of line
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kotlovs commented on a change in pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
kotlovs commented on a change in pull request #32080:
URL: https://github.com/apache/spark/pull/32080#discussion_r609089318
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1031,6 +1031,8 @@ object SparkSubmit extends CommandLineUtils with Logging {
} catch {
case e: SparkUserAppException =>
exitFn(e.exitCode)
+ case _: Throwable =>
+ exitFn(1)
Review comment:
This changes will not fix [the problem](https://issues.apache.org/jira/browse/SPARK-34674) completely.
If the main() method completes successfully, the application will still hang in K8S.
Could you consider also call to exitFn in case of successfull?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] KarlManong commented on a change in pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
KarlManong commented on a change in pull request #32080:
URL: https://github.com/apache/spark/pull/32080#discussion_r609291585
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1031,6 +1031,8 @@ object SparkSubmit extends CommandLineUtils with Logging {
} catch {
case e: SparkUserAppException =>
exitFn(e.exitCode)
+ case _: Throwable =>
+ exitFn(1)
Review comment:
Yes, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] KarlManong commented on pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
KarlManong commented on pull request #32080:
URL: https://github.com/apache/spark/pull/32080#issuecomment-815440922
> BTW, this doesn't look like [SPARK-34674](https://issues.apache.org/jira/browse/SPARK-34674) because the case in [SPARK-34674](https://issues.apache.org/jira/browse/SPARK-34674) ends without throwing `Exception`. I'd like to recommend to have a separate JIRA issue if your case is considering unhandled `Exception` from your apps. It could be a general `spark-submit` issue for all resource managers like Mesos.
Yes, my mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] KarlManong closed pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
KarlManong closed pull request #32080:
URL: https://github.com/apache/spark/pull/32080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32080: [SPARK-34674] Spark app on k8s doesn't terminate without call to sparkContext.stop() method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32080:
URL: https://github.com/apache/spark/pull/32080#issuecomment-815123667
BTW, this doesn't look like SPARK-34674 because the case in SPARK-34674 ends without throwing `Exception`. I'd like to recommend to have a separate JIRA issue if your case is considering unhandled `Exception` from your apps. It could be a general `spark-submit` issue for all resource managers like Mesos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org