You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/14 04:33:19 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #39047: [SPARK-41506][CONNECT][PYTHON] Refactor LiteralExpression to support DataType
cloud-fan commented on code in PR #39047:
URL: https://github.com/apache/spark/pull/39047#discussion_r1048005530
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -77,9 +77,7 @@ message Expression {
int32 year_month_interval = 20;
int64 day_time_interval = 21;
- Array array = 22;
- Struct struct = 23;
- Map map = 24;
+ DataType typed_null = 22;
Review Comment:
where do we read this field at the server side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org