You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/10/19 13:24:48 UTC
Review Request 63146: Replaced std::cerr by LOG(ERROR) in process.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63146/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/src/process.cpp 2334e2656dddbaa0b3532715e0a18132e1b898fd
Diff: https://reviews.apache.org/r/63146/diff/1/
Testing
-------
```
$ make check
```
Thanks,
Armand Grillet
Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in
process.cpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63146/#review188736
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63146]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 19, 2017, 1:24 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63146/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 1:24 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 2334e2656dddbaa0b3532715e0a18132e1b898fd
>
>
> Diff: https://reviews.apache.org/r/63146/diff/2/
>
>
> Testing
> -------
>
> ```
> $ make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in
process.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63146/#review188692
-----------------------------------------------------------
PASS: Mesos patch 63146 was successfully built and tested.
Reviews applied: `['63146']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63146
- Mesos Reviewbot Windows
On Oct. 19, 2017, 1:24 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63146/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 1:24 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 2334e2656dddbaa0b3532715e0a18132e1b898fd
>
>
> Diff: https://reviews.apache.org/r/63146/diff/1/
>
>
> Testing
> -------
>
> ```
> $ make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in
process.cpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63146/#review188684
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63146]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 19, 2017, 4:24 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63146/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 4:24 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 2334e2656dddbaa0b3532715e0a18132e1b898fd
>
>
> Diff: https://reviews.apache.org/r/63146/diff/1/
>
>
> Testing
> -------
>
> ```
> $ make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in
process.cpp.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63146/#review188730
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/process.cpp
Line 49 (original), 49 (patched)
<https://reviews.apache.org/r/63146/#comment265759>
I don't think we need this now.
- Alexander Rukletsov
On Oct. 19, 2017, 1:24 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63146/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 1:24 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 2334e2656dddbaa0b3532715e0a18132e1b898fd
>
>
> Diff: https://reviews.apache.org/r/63146/diff/2/
>
>
> Testing
> -------
>
> ```
> $ make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 63146: Replaced std::cerr by LOG(ERROR) in
process.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63146/#review188738
-----------------------------------------------------------
PASS: Mesos patch 63146 was successfully built and tested.
Reviews applied: `['63146']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63146
- Mesos Reviewbot Windows
On Oct. 19, 2017, 1:24 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63146/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2017, 1:24 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 2334e2656dddbaa0b3532715e0a18132e1b898fd
>
>
> Diff: https://reviews.apache.org/r/63146/diff/2/
>
>
> Testing
> -------
>
> ```
> $ make check
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>