You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2026/09/09 05:11:50 UTC

[GH] (rocketmq-dashboard/fix/inconsistent-system-topic-filtering-1407): Workflow run "CI" failed!

The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/inconsistent-system-topic-filtering-1407 has failed.
Run started by GitHub user tju-yxq (triggered by tju-yxq).

Head commit for run:
d5feb4d422a4c6fe420a9e7f813cc2556ffe9ed0 / Yxq <30...@tju.edu.cn>
[ISSUE #1407] Unify system topic filtering across providers

Two separate isSystemTopic implementations had inconsistent filtering
rules, causing system topics to leak into topic lists and inflate
dashboard topic counts. Key discrepancies:

- CID_ prefix was in MetadataProvider but not DashboardProvider
- broker_ prefix was in DashboardProvider but not MetadataProvider
- DashboardProvider had hardcoded broker-a/broker-b names
- DashboardProvider did not check live broker names as system topics

This fix:
- Extracts a shared SystemTopicFilter utility class
- Replaces both implementations with calls to the shared method
- Removes hardcoded broker-a/broker-b from DashboardProvider
- Adds CID_, broker_, BenchmarkTest to the unified filter

Fixes #1407

Report URL: https://github.com/apache/rocketmq-dashboard/actions/runs/31357725420

With regards,
GitHub Actions via GitBox