[GitHub] [iceberg] rdblue commented on a change in pull request #1469: Add position delete validation that data files have not been deleted

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1469:
URL: https://github.com/apache/iceberg/pull/1469#discussion_r499730565



##########
File path: core/src/main/java/org/apache/iceberg/BaseRowDelta.java
##########
@@ -45,4 +62,80 @@ public RowDelta addDeletes(DeleteFile deletes) {
     add(deletes);
     return this;
   }
+
+  @Override
+  public RowDelta validateFromSnapshot(long snapshotId) {
+    this.startingSnapshotId = snapshotId;
+    return this;
+  }
+
+  @Override
+  public RowDelta validateDeletedFiles() {
+    return validateDeletedFiles(true);
+  }
+
+  public RowDelta validateDeletedFiles(boolean shouldValidate) {

Review comment:
       No. I was debating whether to add it to the public API, so it was initially public. But I decided to keep the public API minimal for now. We can always add it later. That's why I kept it here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org