You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/30 07:54:21 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4341: Allow to configure root disk size via Service Offering (diskoffering of type Service).

DaanHoogland commented on a change in pull request #4341:
URL: https://github.com/apache/cloudstack/pull/4341#discussion_r514922644



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -1183,24 +1183,27 @@ private UserVm upgradeStoppedVirtualMachine(Long vmId, Long svcOffId, Map<String
         // Check that the specified service offering ID is valid
         _itMgr.checkIfCanUpgrade(vmInstance, newServiceOffering);
 
-        DiskOfferingVO newROOTDiskOffering = _diskOfferingDao.findById(newServiceOffering.getId());
+        // Check if the new service offering can be applied to vm instance

Review comment:
       this comment could be a method name instead `canServiceOfferingBeAppliedToInstance(...)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org