You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/07/06 14:13:23 UTC
[GitHub] [brooklyn-server] algairim opened a new pull request #1194: Add search by phrase, use better parameter names; more unit-tests
algairim opened a new pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194
Signed-off-by: Mykola Mandra <my...@cloudsoftcorp.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] algairim commented on pull request #1194: Add search by phrase, use better parameter names; more unit-tests
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194#issuecomment-874825868
Requires https://github.com/apache/brooklyn-ui/pull/240 to be merge in after, since it changes the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] algairim commented on a change in pull request #1194: Add search by phrase, use better parameter names; more unit-tests
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194#discussion_r664753699
##########
File path: core/src/main/java/org/apache/brooklyn/util/core/logbook/LogBookQueryParams.java
##########
@@ -20,12 +20,28 @@
import java.util.List;
+/**
+ * The logbook query parameters.
+ */
public class LogBookQueryParams {
+
+ /** The number of log items to query. Note, one log item can be a multi-line one, e.g. a stacktrace */
private Integer numberOfItems;
+
+ /** The indicator whether to return logs in reverse order */
private Boolean reverseOrder;
+
+ /** The log levels: INFO, FATAL, ERROR, DEBUG or WARNING */
private List<String> levels;
- private String initTime;
- private String finalTime;
+
+ /** The date-time to look log items from */
+ private String dateTimeFrom;
Review comment:
Calendar input does take timezone into account though.
<img width="1173" alt="Screenshot 2021-07-06 at 18 35 50" src="https://user-images.githubusercontent.com/81319331/124643421-fe66ca80-de88-11eb-9bfe-dc4dce657452.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] algairim commented on a change in pull request #1194: Add search by phrase, use better parameter names; more unit-tests
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194#discussion_r664600953
##########
File path: core/src/test/resources/brooklyn/util/core/logbook/file/log-sample.txt
##########
@@ -0,0 +1,8 @@
+2021-05-27T11:36:59,251 - DEBUG 146 o.a.b.c.m.i.LocalManagementContext [qtp158784971-235] Top-level effector invocation: restart[] on BasicApplicationImpl{id=gwpndj09r8, name=Application (gwpndj09r8)}
Review comment:
This is a realistic log sample
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] algairim commented on a change in pull request #1194: Add search by phrase, use better parameter names; more unit-tests
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194#discussion_r664750243
##########
File path: core/src/main/java/org/apache/brooklyn/util/core/logbook/LogBookQueryParams.java
##########
@@ -20,12 +20,28 @@
import java.util.List;
+/**
+ * The logbook query parameters.
+ */
public class LogBookQueryParams {
+
+ /** The number of log items to query. Note, one log item can be a multi-line one, e.g. a stacktrace */
private Integer numberOfItems;
+
+ /** The indicator whether to return logs in reverse order */
private Boolean reverseOrder;
+
+ /** The log levels: INFO, FATAL, ERROR, DEBUG or WARNING */
private List<String> levels;
- private String initTime;
- private String finalTime;
+
+ /** The date-time to look log items from */
+ private String dateTimeFrom;
Review comment:
Not my choice but a valid point. Looks like LocalDateTime is more appropriate, timezone is not required. What do you think @duncangrant ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] algairim commented on a change in pull request #1194: Add search by phrase, use better parameter names; more unit-tests
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194#discussion_r664753699
##########
File path: core/src/main/java/org/apache/brooklyn/util/core/logbook/LogBookQueryParams.java
##########
@@ -20,12 +20,28 @@
import java.util.List;
+/**
+ * The logbook query parameters.
+ */
public class LogBookQueryParams {
+
+ /** The number of log items to query. Note, one log item can be a multi-line one, e.g. a stacktrace */
private Integer numberOfItems;
+
+ /** The indicator whether to return logs in reverse order */
private Boolean reverseOrder;
+
+ /** The log levels: INFO, FATAL, ERROR, DEBUG or WARNING */
private List<String> levels;
- private String initTime;
- private String finalTime;
+
+ /** The date-time to look log items from */
+ private String dateTimeFrom;
Review comment:
Calendar input does take timezone into account though.
<img width="1173" alt="Screenshot 2021-07-06 at 18 35 50" src="https://user-images.githubusercontent.com/81319331/124643421-fe66ca80-de88-11eb-9bfe-dc4dce657452.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] duncangrant commented on a change in pull request #1194: Add search by phrase, use better parameter names; more unit-tests
Posted by GitBox <gi...@apache.org>.
duncangrant commented on a change in pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194#discussion_r664718572
##########
File path: core/src/main/java/org/apache/brooklyn/util/core/logbook/LogBookQueryParams.java
##########
@@ -20,12 +20,28 @@
import java.util.List;
+/**
+ * The logbook query parameters.
+ */
public class LogBookQueryParams {
+
+ /** The number of log items to query. Note, one log item can be a multi-line one, e.g. a stacktrace */
private Integer numberOfItems;
+
+ /** The indicator whether to return logs in reverse order */
private Boolean reverseOrder;
+
+ /** The log levels: INFO, FATAL, ERROR, DEBUG or WARNING */
private List<String> levels;
- private String initTime;
- private String finalTime;
+
+ /** The date-time to look log items from */
+ private String dateTimeFrom;
Review comment:
why isn't this a date?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] duncangrant merged pull request #1194: Add search by phrase, use better parameter names; more unit-tests
Posted by GitBox <gi...@apache.org>.
duncangrant merged pull request #1194:
URL: https://github.com/apache/brooklyn-server/pull/1194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org