You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/29 19:34:14 UTC
[GitHub] [beam] nancyxu123 commented on a diff in pull request #24390: [BEAM-12164] Support querying against Postgres for the SpannerIO change streams connector
nancyxu123 commented on code in PR #24390:
URL: https://github.com/apache/beam/pull/24390#discussion_r1035198093
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/mapper/ChangeStreamRecordMapper.java:
##########
@@ -260,6 +312,65 @@ private DataChangeRecord toDataChangeRecord(
changeStreamRecordMetadataFrom(partition, commitTimestamp, resultSetMetadata));
}
+ private DataChangeRecord toDataChangeRecordJson(
+ PartitionMetadata partition, Value row, ChangeStreamResultSetMetadata resultSetMetadata) {
+ Value dataChangeRecordValue =
+ Optional.ofNullable(row.getStructValue().getFieldsMap().get(DATA_CHANGE_RECORD_COLUMN))
+ .orElseThrow(IllegalArgumentException::new);
+ Map<String, Value> valueMap = dataChangeRecordValue.getStructValue().getFieldsMap();
+ final String commitTimestamp =
+ Optional.ofNullable(valueMap.get(COMMIT_TIMESTAMP_COLUMN))
+ .orElseThrow(IllegalArgumentException::new)
+ .getStringValue();
+ return new DataChangeRecord(
+ partition.getPartitionToken(),
+ Timestamp.parseTimestamp(commitTimestamp),
+ Optional.ofNullable(valueMap.get(SERVER_TRANSACTION_ID_COLUMN))
+ .orElseThrow(IllegalArgumentException::new)
Review Comment:
Yes, I doublechecked.
See JSON string for data change record: Jsonb: {"data_change_record":{"column_types":[{"is_primary_key":true,"name":"SingerId","ordinal_position":1,"type":{"code":"INT64"}},{"is_primary_key":false,"name":"FirstName","ordinal_position":2,"type":{"code":"STRING"}},{"is_primary_key":false,"name":"LastName","ordinal_position":3,"type":{"code":"STRING"}},{"is_primary_key":false,"name":"SingerInfo","ordinal_position":4,"type":{"code":"BYTES"}}],"commit_timestamp":"2022-11-29T11:31:36.008927-08:00","is_last_record_in_transaction_in_partition":true,"is_system_transaction":false,"mod_type":"INSERT","mods":[{"keys":{"SingerId":"2"},"new_values":{"FirstName":"First Name 2","LastName":"Last Name 2","SingerInfo":null},"old_values":{}}],"number_of_partitions_in_transaction":1,"number_of_records_in_transaction":1,"record_sequence":"00000000","server_transaction_id":"NTczMzU4MTQ3MzQyNzAyNjA0Ng==","table_name":"Singers_qqkl32uoQ1Rhk4ZDqW4KGy2f1oGyhLH6oiiXq71B5U24ZLbTylFANYz","transaction_tag":
"","value_capture_type":"OLD_AND_NEW_VALUES"}}
See JSON string for child partitions record: Jsonb: {"child_partitions_record":{"child_partitions":[{"parent_partition_tokens":[],"token":"__8BAYEGX9zUgAABgsBFg1NpbmdlcnNTdHJlYW1fODVxa29vZHBkM3ZOQUFvOAABhIEGCRQ28AANgoCDCMNkAAAAAAAAhASSRgwFhWcxM185NTE5OTgzAAH__4X_Be6gldXMFYb_Be6hGsHih4eAwGQBAf__"}],"record_sequence":"00000002","start_timestamp":"2022-11-29T11:31:35.951359-08:00"}}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org