[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #872: fix ingress delete panic

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #872:
URL: https://github.com/apache/apisix-ingress-controller/pull/872#discussion_r811012198



##########
File path: pkg/ingress/ingress.go
##########
@@ -192,18 +192,20 @@ func (c *ingressController) handleSyncErr(obj interface{}, err error) {
 	event := ev.Object.(kube.IngressEvent)
 	namespace, name, errLocal := cache.SplitMetaNamespaceKey(event.Key)
 	if errLocal != nil {
-		log.Errorf("invalid resource key: %s", event.Key)
+		log.Errorw("invalid resource key",

Review comment:
       I think still reserve the `key` in the log will be better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org