[jira] Updated: (ODE-236) Add support for from-spec inside a variable declaration to initialize it. . This is a standard BPEL 2.0 construct

["Madars Vitolins (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Madars Vitolins updated ODE-236:
--------------------------------

    Attachment: inline-var-init-trunk-rev-764976-20090415.patch

Hello Oders!

I have attached patch for inline variable initialization (file: inline-var-init-trunk-rev-764976-20090415.patch).
It also includes compiler and runtime test cases.

This new functionality extensively reuses already existing code for "<assign><copy><from>" elements.
Please can you review my patch and give any comments/advices if something should be changed?

Here is some points to consider:
1. OScope.variables object type changed from HashMap to LinkedHashMap (so the variables can be initialized from previous in the same scope)
2. At runtime variable initialization is done when SCOPE is created (in constructor)
3. For ASSIGN activity some methods made public
4. SCOPE at variable initialization temporary creates  ASSIGN activity to call some of it's public methods

For 3. & 4. maybe some utility class would help (where do you put such?) Or... leave as is?

Thanks,
Madars

> Add support for from-spec inside a variable declaration to initialize it. . This is a standard BPEL 2.0 construct
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: ODE-236
>                 URL: https://issues.apache.org/jira/browse/ODE-236
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Runtime
>    Affects Versions: 1.1.1
>            Reporter: Hugues Malphettes
>             Fix For: 2.0
>
>         Attachments: inline-var-init-trunk-rev-764976-20090415.patch
>
>
> This limitation is listed here:
> http://cwiki.apache.org/confluence/display/ODExSITE/WS-BPEL+2.0+Specification+Compliance#WS-BPEL2.0SpecificationCompliance-Initialization

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: Inline variable initialization patch

[Matthieu Riou <ma...@gmail.com>]

On Wed, Apr 15, 2009 at 9:19 AM, Madars Vitolins <m...@silodev.eu> wrote:

> Hello,
>
> Could anybody check patch I have uploaded to
>
> https://issues.apache.org/jira/browse/ODE-236
>
>
> and if it is OK, apply to trunk?
> If not, then any comments/suggestions are welcome!
>

Sorry it's in my TODO list but reviewing longer patches take some time.
Looks like a very promising patch though, thanks a lot! I'll let you know as
soon as I have more time for a more thorough review.

Matthieu


>
> Thanks in advance,
> Madars
>
>
>
>
>
>

Inline variable initialization patch

[Madars Vitolins <m...@silodev.eu>]

Hello,

Could anybody check patch I have uploaded to

https://issues.apache.org/jira/browse/ODE-236


and if it is OK, apply to trunk?
If not, then any comments/suggestions are welcome!

Thanks in advance,
Madars