You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/29 13:58:00 UTC

[GitHub] [camel] orpiske commented on pull request #7286: Add singleton support for more test infra services:

orpiske commented on pull request #7286:
URL: https://github.com/apache/camel/pull/7286#issuecomment-1081906313


   > Hi @orpiske, it is not related directly to your change but I was wondering why we need to call [`getLogger` in the function `defaultCreator`](https://github.com/apache/camel/blob/63d6a8bf425145450a827d60cdbf25d194a4a381/test-infra/camel-test-infra-common/src/test/java/org/apache/camel/test/infra/common/services/SingletonService.java#L39). Could it be a static field instead?
   
   Thanks for pointing it out. It should be static field. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org