You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/24 20:22:35 UTC
[GitHub] [flink] bowenli86 commented on a change in pull request #9962:
[FLINK-14218][table] support precise function reference in FunctionCatalog
bowenli86 commented on a change in pull request #9962: [FLINK-14218][table] support precise function reference in FunctionCatalog
URL: https://github.com/apache/flink/pull/9962#discussion_r338773844
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -345,16 +345,18 @@ public void createFunction(ObjectPath functionPath, CatalogFunction function, bo
checkNotNull(functionPath);
checkNotNull(function);
- if (!databaseExists(functionPath.getDatabaseName())) {
- throw new DatabaseNotExistException(getName(), functionPath.getDatabaseName());
+ ObjectPath path = normalize(functionPath);
Review comment:
That's indeed a simpler way, but as mentioned in the description, I'm afraid that would impact other objects like tables. The current assumption in Flink is function names are case insensitive and other object names are case sensitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services