[GitHub] wes3 commented on issue #366: bsp: Fix nRF5x BSP configurations for BLE_LP_CLOCK

[gi...@git.apache.org]

wes3 commented on issue #366: bsp: Fix nRF5x BSP configurations for BLE_LP_CLOCK
URL: https://github.com/apache/mynewt-core/pull/366#issuecomment-312333589
 
 
   Some comments:
   
   * Looking at the bmd200 syscfg.yml and microbit I see this in the bmd200:
       XTAL_32768:
           description: 'External 32k oscillator available.'
           value: 0
           restrictions:
               - "!XTAL_32768_SYNTH"
   
       XTAL_32768_SYNTH:
           description: 'Synthesize 32k clock.'
           value: 1
           restrictions:
               - "!XTAL_32768"
   
   In the microbit syscfg.yml I do not see XTAL_32768 set to 0 (or that syscfg variable at all). Hopefully I am looking at the latest.
   
   * The code can still use the low power clock without an external crystal; it just needs to use the synthesized crystal. I have not looked at this in a bit but I think when the synthesized crystal is used the accuracy of the clock (SCA) is affected and I am not sure this is accounted for in the code. I think this needs to be reviewed before merging this pull request.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services