[GitHub] [iceberg] rdblue commented on a change in pull request #2847: [2806]Dell EMC ECS features required by a new ECS Catalog impl

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2847:
URL: https://github.com/apache/iceberg/pull/2847#discussion_r701232798



##########
File path: build.gradle
##########
@@ -406,6 +406,7 @@ project(':iceberg-flink-runtime') {
     compile(project(':iceberg-nessie')) {
       exclude group: 'com.google.code.findbugs', module: 'jsr305'
     }
+    compile(project(':iceberg-dell'))

Review comment:
       Please remove additions to the runtime Jars until later. We add new integrations to the runtime Jars after they are finished, and we also look at the dependencies that are added to the runtime Jar as a result. We need to be careful with runtime Jar licensing.
   
   I don't think that we want to start worrying about updating LICENSE files and looking at sizes just yet.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org