You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Yaolong Liu (Jira)" <ji...@apache.org> on 2022/08/26 16:08:00 UTC
[jira] [Commented] (RATIS-1689) Remove the use of the thirdparty Gauge
[ https://issues.apache.org/jira/browse/RATIS-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585520#comment-17585520 ]
Yaolong Liu commented on RATIS-1689:
------------------------------------
[~szetszwo] Hi Tsz-Wo, by reading the description, I still don't fully understand. For better code review, could you explain why we only remove Guage related code? I mean, why is Guage special, and we don't need to remove Counter, Timer related code. Thanks!
> Remove the use of the thirdparty Gauge
> --------------------------------------
>
> Key: RATIS-1689
> URL: https://issues.apache.org/jira/browse/RATIS-1689
> Project: Ratis
> Issue Type: Sub-task
> Components: metrics
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Remove the use of org.apache.ratis.thirdparty.com.codahale.metrics.Gauge from the public metrics API* and the main Ratis code. Note that the tests and metrics implementations can use it.
> \* We currently do not have. a clear definition of the public metrics API yet. Some of the current interfaces such as RatisMetricRegistry are going to be a part of the public API.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)