You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2023/04/14 20:07:40 UTC
[GitHub] [arrow-datafusion] comphead opened a new pull request, #6015: infer column nullability on joins
comphead opened a new pull request, #6015:
URL: https://github.com/apache/arrow-datafusion/pull/6015
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5994 .
# Rationale for this change
Fix bugs reported in #5994
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead closed pull request #6015: infer column nullability on joins
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead closed pull request #6015: infer column nullability on joins
URL: https://github.com/apache/arrow-datafusion/pull/6015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6015: infer column nullability on joins
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #6015:
URL: https://github.com/apache/arrow-datafusion/pull/6015#discussion_r1168973195
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1041,11 +1041,18 @@ pub fn build_join_schema(
right: &DFSchema,
join_type: &JoinType,
) -> Result<DFSchema> {
+ fn nullify_fields(fields: &[DFField]) -> Vec<DFField> {
Review Comment:
Thanks @alamb
This fixes partially #5747
I will investigate what is the use case for [arrow-datafusion/datafusion/core/src/physical_plan/joins/utils.rs](https://github.com/apache/arrow-datafusion/blob/5b9db17528910328d6ea00d5a6a81138ac6a680b/datafusion/core/src/physical_plan/joins/utils.rs#L349)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6015: infer column nullability on joins
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6015:
URL: https://github.com/apache/arrow-datafusion/pull/6015#discussion_r1168475782
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1041,11 +1041,18 @@ pub fn build_join_schema(
right: &DFSchema,
join_type: &JoinType,
) -> Result<DFSchema> {
+ fn nullify_fields(fields: &[DFField]) -> Vec<DFField> {
Review Comment:
It seems like there are two build_join_schema functions: https://github.com/search?q=repo%3Aapache%2Farrow-datafusion+build_join_schema&type=code
The one in the `datafusion` module already seems to do the right thing with nulls: https://github.com/apache/arrow-datafusion/blob/5b9db17528910328d6ea00d5a6a81138ac6a680b/datafusion/core/src/physical_plan/joins/utils.rs#L349
A nice follow on PR might be to refactor the code so that only one copy of build_join_schema is present and is used in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6015: infer column nullability on joins
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #6015:
URL: https://github.com/apache/arrow-datafusion/pull/6015#discussion_r1170166849
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1041,11 +1041,18 @@ pub fn build_join_schema(
right: &DFSchema,
join_type: &JoinType,
) -> Result<DFSchema> {
+ fn nullify_fields(fields: &[DFField]) -> Vec<DFField> {
Review Comment:
Filed https://github.com/apache/arrow-datafusion/issues/6046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on pull request #6015: infer column nullability on joins
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #6015:
URL: https://github.com/apache/arrow-datafusion/pull/6015#issuecomment-1514915268
oops I overwrote the branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org