You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/01/23 16:44:12 UTC

[GitHub] flink pull request #5343: [FLINK-8496][metrics] Create missing "Network" gro...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5343

    [FLINK-8496][metrics] Create missing "Network" group

    ## What is the purpose of the change
    
    This PR reverts a change to the metric names for the AvailableMemorySegments/TotalMemorySegments metrics. The "Network" MetricGroup creation as accidentally removed in a previous refactoring (7fb7e0b9775d1773d20e63732130ae140781a6f2) causing the metric to no longer be displayed in the UI.
    
    ## Verifying this change
    
    Start a cluster and check the Memory Segment metrics in the taskmanager tab, which should be greater than 0.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8496

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5343
    
----
commit 73322f6e3e3391c4ee29b3423e03e7410106c425
Author: zentol <ch...@...>
Date:   2018-01-23T16:32:44Z

    [FLINK-8496][metrics] Create missing "Network" group

----


---

[GitHub] flink issue #5343: [FLINK-8496][metrics] Create missing "Network" group

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5343
  
    From eyeballing this change it seems correct. I'm assuming you did that manual check so I'd say this is good to go.


---

[GitHub] flink issue #5343: [FLINK-8496][metrics] Create missing "Network" group

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5343
  
    merging.


---

[GitHub] flink pull request #5343: [FLINK-8496][metrics] Create missing "Network" gro...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5343


---