You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/17 15:03:36 UTC

[GitHub] [cordova-ios] msmtamburro opened a new issue #904: MainViewController.m omit empty `viewDidLoad` to avoid warnings

msmtamburro opened a new issue #904:
URL: https://github.com/apache/cordova-ios/issues/904


   # Bug Report
   
   ## Problem
   
   Thanks for removing the deprecated viewDidUnload!  If you also remove some of the other empty methods (e.g., `viewDidLoad`) this gives developers a way to easily create an extension on MainViewController.m to implement those methods without warning.
   
   ### What is expected to happen?
   
   A developer should be able to implement `viewDidLoad` in MainViewController.m
   
   ### What does actually happen?
   
   Using the existing stub creates either architectural issues (e.g., changing a file that will get overwritten) or warnings (as mentioned the extension approach above).
   
   ## Information
   <!-- Include all relevant information that might help understand and reproduce the problem -->
   
   You might just remove all empty methods, and replace them with a comment like:
   _The_ best way to customize `viewDidLoad` is to make a Swift Extension of MainViewController and implement the method there.  You can add your extension to your project by including it in a plugin._
   
   ### Command or Code
   <!-- What command or code is needed to reproduce the problem? -->
   
   
   
   ### Environment, Platform, Device
   <!-- In what environment, on what platform or on which device are you experiencing the issue? -->
   
   
   
   ### Version information
   <!-- 
   What are relevant versions you are using?
   For example:
   Cordova: Cordova CLI, Cordova Platforms, Cordova Plugins 
   Other Frameworks: Ionic Framework and CLI version
   Operating System, Android Studio, Xcode etc.
   -->
   
   
   
   ## Checklist
   <!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
   
   - [x] I searched for existing GitHub issues
   - [x] I updated all Cordova tooling to most recent version
   - [x] I included all the necessary information above
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org