[GitHub] [incubator-dolphinscheduler] Yeleights commented on a change in pull request #1919: Add modify user name for process definition

[GitBox <gi...@apache.org>]

Yeleights commented on a change in pull request #1919: Add modify user name for process definition
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1919#discussion_r376879133
 
 

 ##########
 File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ScriptRunner.java
 ##########
 @@ -169,13 +169,13 @@ private void runScript(Connection conn, Reader reader) throws IOException, SQLEx
                             if (stopOnError && rs != null) {
                                 ResultSetMetaData md = rs.getMetaData();
                                 int cols = md.getColumnCount();
-                                for (int i = 0; i < cols; i++) {
+                                for (int i = 1; i < cols; i++) {
 
 Review comment:
   because in pgsql: The number of columns starts from "1" and cannot start from "0". 
   i have test this modify in mysql-5.6 and pg-9.6

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services