You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/07 16:40:54 UTC
[GitHub] [superset] wanghong1314 opened a new pull request, #22635: fix: Stop query in SQL Lab with impala engine (#20950)
wanghong1314 opened a new pull request, #22635:
URL: https://github.com/apache/superset/pull/22635
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
fix(sqllab): Stop button for queries doesn't work in SQL Lab when using SQL Lab with impala engine and adding Progress Information
Fix the bug:https://github.com/apache/superset/issues/20950
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
BEFORE
AFTER
progress info
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wanghong1314 commented on a diff in pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
wanghong1314 commented on code in PR #22635:
URL: https://github.com/apache/superset/pull/22635#discussion_r1065538325
##########
superset/db_engine_specs/impala.py:
##########
@@ -14,20 +14,31 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+import logging
+import re
+import time
from datetime import datetime
from typing import Any, Dict, List, Optional
+from flask import current_app
from sqlalchemy.engine.reflection import Inspector
+from sqlalchemy.orm import Session
+from superset.constants import QUERY_EARLY_CANCEL_KEY
from superset.db_engine_specs.base import BaseEngineSpec
+from superset.models.sql_lab import Query
from superset.utils import core as utils
+logger = logging.getLogger(__name__)
+
class ImpalaEngineSpec(BaseEngineSpec):
"""Engine spec for Cloudera's Impala"""
engine = "impala"
engine_name = "Apache Impala"
+ # Query 5543ffdf692b7d02:f78a944000000000: 3% Complete (17 out of 547)
+ query_progress_r = re.compile(r".*Query.*: (?P<query_progress>[0-9]+)%.*")
Review Comment:
Thank you for your comments. I have no problem changing the test here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wanghong1314 commented on a diff in pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
wanghong1314 commented on code in PR #22635:
URL: https://github.com/apache/superset/pull/22635#discussion_r1065434307
##########
superset/config.py:
##########
@@ -1129,8 +1129,10 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC( # pylint: disable=invalid-name
TRACKING_URL_TRANSFORMER = lambda url: url
-# Interval between consecutive polls when using Hive Engine
-HIVE_POLL_INTERVAL = int(timedelta(seconds=5).total_seconds())
+# customize the polling time of each engine. The default time is 5 seconds
+DB_POLL_INTERVAL_SECONDS = {
+ "hive": int(timedelta(seconds=5).total_seconds()),
+}
Review Comment:
OK, thank you for your suggestion. I can let the user set it without setting the default value. I want to change it to this?
DB_POLL_INTERVAL_SECONDS = {}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22635:
URL: https://github.com/apache/superset/pull/22635#issuecomment-1376782496
# [Codecov](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22635](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7da3cd) into [master](https://codecov.io/gh/apache/superset/commit/1bc2237768112428356b46aa889905af2a6164b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bc2237) will **decrease** coverage by `11.12%`.
> The diff coverage is `32.78%`.
```diff
@@ Coverage Diff @@
## master #22635 +/- ##
===========================================
- Coverage 67.03% 55.90% -11.13%
===========================================
Files 1859 1859
Lines 71043 71102 +59
Branches 7776 7776
===========================================
- Hits 47622 39749 -7873
- Misses 21397 29329 +7932
Partials 2024 2024
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.44% <32.78%> (-0.04%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.33% <27.86%> (-0.05%)` | :arrow_down: |
| python | `58.12% <32.78%> (-23.26%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `51.44% <27.86%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | `38.46% <27.77%> (-44.88%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `35.59% <50.00%> (-39.40%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `64.59% <75.00%> (-22.82%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.07% <100.00%> (-0.60%)` | :arrow_down: |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/tags/core.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFncy9jb3JlLnB5) | `4.54% <0.00%> (-95.46%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `0.00% <0.00%> (-87.88%)` | :arrow_down: |
| [superset/key\_value/commands/delete\_expired.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZV9leHBpcmVkLnB5) | `0.00% <0.00%> (-84.00%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `15.62% <0.00%> (-76.25%)` | :arrow_down: |
| ... and [288 more](https://codecov.io/gh/apache/superset/pull/22635?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22635:
URL: https://github.com/apache/superset/pull/22635#discussion_r1065404439
##########
superset/db_engine_specs/impala.py:
##########
@@ -14,20 +14,31 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+import logging
+import re
+import time
from datetime import datetime
from typing import Any, Dict, List, Optional
+from flask import current_app
from sqlalchemy.engine.reflection import Inspector
+from sqlalchemy.orm import Session
+from superset.constants import QUERY_EARLY_CANCEL_KEY
from superset.db_engine_specs.base import BaseEngineSpec
+from superset.models.sql_lab import Query
from superset.utils import core as utils
+logger = logging.getLogger(__name__)
+
class ImpalaEngineSpec(BaseEngineSpec):
"""Engine spec for Cloudera's Impala"""
engine = "impala"
engine_name = "Apache Impala"
+ # Query 5543ffdf692b7d02:f78a944000000000: 3% Complete (17 out of 547)
+ query_progress_r = re.compile(r".*Query.*: (?P<query_progress>[0-9]+)%.*")
Review Comment:
nit: do we really need the leading and trailing `.*` here?
```suggestion
query_progress_r = re.compile(r"Query.*: (?P<query_progress>[0-9]+)%")
```
Also, I know this is in line with what's being done in `hive.py`, but I would consider moving this outside the class into a constant `QUERY_PROGRESS_REGEX` in `impala.py`, as it's not defined in `BaseEngineSpec` (defining it here makes it appear like we're overriding a class attribute in `BaseEngineSpec`). While at it, maybe do the same for `stage_progress_r` in `HiveEngineSpec`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22635:
URL: https://github.com/apache/superset/pull/22635#discussion_r1065404439
##########
superset/db_engine_specs/impala.py:
##########
@@ -14,20 +14,31 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+import logging
+import re
+import time
from datetime import datetime
from typing import Any, Dict, List, Optional
+from flask import current_app
from sqlalchemy.engine.reflection import Inspector
+from sqlalchemy.orm import Session
+from superset.constants import QUERY_EARLY_CANCEL_KEY
from superset.db_engine_specs.base import BaseEngineSpec
+from superset.models.sql_lab import Query
from superset.utils import core as utils
+logger = logging.getLogger(__name__)
+
class ImpalaEngineSpec(BaseEngineSpec):
"""Engine spec for Cloudera's Impala"""
engine = "impala"
engine_name = "Apache Impala"
+ # Query 5543ffdf692b7d02:f78a944000000000: 3% Complete (17 out of 547)
+ query_progress_r = re.compile(r".*Query.*: (?P<query_progress>[0-9]+)%.*")
Review Comment:
nit: do we really need the leading and trailing `.*` here?
```suggestion
query_progress_r = re.compile(r"Query.*: (?P<query_progress>[0-9]+)%")
```
Also, I know this is in line with what's being done in `hive.py`, but I would consider moving this outside the class into a constant `QUERY_PROGRESS_REGEX` in `impala.py`, as it's not defined in `BaseEngineSpec (defining it here makes it appear like we're overriding a class attribute in `BaseEngineSpec`). While at it, maybe do the same for `stage_progress_r` in `HiveEngineSpec`.
##########
superset/db_engine_specs/hive.py:
##########
@@ -375,7 +375,15 @@ def handle_cursor( # pylint: disable=too-many-locals
last_log_line = len(log_lines)
if needs_commit:
session.commit()
- time.sleep(current_app.config["HIVE_POLL_INTERVAL"])
+ if sleep_interval := current_app.config.get("HIVE_POLL_INTERVAL"):
+ logger.warning(
+ "HIVE_POLL_INTERVAL is deprecated and will be removed in 3.0. Please use DB_POLL_INTERVAL instead"
Review Comment:
The deprecation warning is incorrect:
```suggestion
"HIVE_POLL_INTERVAL is deprecated and will be removed in 3.0. Please use DB_POLL_INTERVAL_SECONDS instead"
```
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -106,6 +106,10 @@ class CeleryConfig(object):
WEBDRIVER_BASEURL = "http://superset:8088/"
# The base URL for the email report hyperlinks.
WEBDRIVER_BASEURL_USER_FRIENDLY = WEBDRIVER_BASEURL
+# customize the polling time of each engine. The default time is 5 seconds
+DB_POLL_INTERVAL_SECONDS = {
+ "hive": int(timedelta(seconds=5).total_seconds()),
+}
Review Comment:
I'm not sure if this is needed, as it's not changing the defaults.
##########
superset/config.py:
##########
@@ -1129,8 +1129,10 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC( # pylint: disable=invalid-name
TRACKING_URL_TRANSFORMER = lambda url: url
-# Interval between consecutive polls when using Hive Engine
-HIVE_POLL_INTERVAL = int(timedelta(seconds=5).total_seconds())
+# customize the polling time of each engine. The default time is 5 seconds
+DB_POLL_INTERVAL_SECONDS = {
+ "hive": int(timedelta(seconds=5).total_seconds()),
+}
Review Comment:
We can't really define defaults in `config.py`. Imagine if I want to override the poll interval for "impala" and add the following to `superset_config.py`:
```
DB_POLL_INTERVAL_SECONDS = {"impala": 1}
```
In this case the default for "hive" in `config.py` would be lost. This is why I recommended not defining the defaults in `config.py`, and rather placing them in their respective db engine specs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wanghong1314 commented on pull request #22635: fix: Stop query in SQL Lab with impala engine (#20950)
Posted by GitBox <gi...@apache.org>.
wanghong1314 commented on PR #22635:
URL: https://github.com/apache/superset/pull/22635#issuecomment-1374537884
@eschutho @villebro Please review the code again. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #22635:
URL: https://github.com/apache/superset/pull/22635#discussion_r1065436118
##########
superset/config.py:
##########
@@ -1129,8 +1129,10 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC( # pylint: disable=invalid-name
TRACKING_URL_TRANSFORMER = lambda url: url
-# Interval between consecutive polls when using Hive Engine
-HIVE_POLL_INTERVAL = int(timedelta(seconds=5).total_seconds())
+# customize the polling time of each engine. The default time is 5 seconds
+DB_POLL_INTERVAL_SECONDS = {
+ "hive": int(timedelta(seconds=5).total_seconds()),
+}
Review Comment:
I would add the type as that's the convention in `config.py` and mypy can't infer the type from an empty dict:
```python
DB_POLL_INTERVAL_SECONDS: Dict[str, int] = {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wanghong1314 commented on a diff in pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
wanghong1314 commented on code in PR #22635:
URL: https://github.com/apache/superset/pull/22635#discussion_r1065568926
##########
superset/config.py:
##########
@@ -1129,8 +1129,10 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC( # pylint: disable=invalid-name
TRACKING_URL_TRANSFORMER = lambda url: url
-# Interval between consecutive polls when using Hive Engine
-HIVE_POLL_INTERVAL = int(timedelta(seconds=5).total_seconds())
+# customize the polling time of each engine. The default time is 5 seconds
+DB_POLL_INTERVAL_SECONDS = {
+ "hive": int(timedelta(seconds=5).total_seconds()),
+}
Review Comment:
I changed it to this way. It's true that mypy failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wanghong1314 commented on a diff in pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
wanghong1314 commented on code in PR #22635:
URL: https://github.com/apache/superset/pull/22635#discussion_r1065436790
##########
superset/db_engine_specs/hive.py:
##########
@@ -375,7 +375,15 @@ def handle_cursor( # pylint: disable=too-many-locals
last_log_line = len(log_lines)
if needs_commit:
session.commit()
- time.sleep(current_app.config["HIVE_POLL_INTERVAL"])
+ if sleep_interval := current_app.config.get("HIVE_POLL_INTERVAL"):
+ logger.warning(
+ "HIVE_POLL_INTERVAL is deprecated and will be removed in 3.0. Please use DB_POLL_INTERVAL instead"
Review Comment:
Sorry, I will check it carefully before submitting next time, and I will change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] wanghong1314 commented on a diff in pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
wanghong1314 commented on code in PR #22635:
URL: https://github.com/apache/superset/pull/22635#discussion_r1065435579
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -106,6 +106,10 @@ class CeleryConfig(object):
WEBDRIVER_BASEURL = "http://superset:8088/"
# The base URL for the email report hyperlinks.
WEBDRIVER_BASEURL_USER_FRIENDLY = WEBDRIVER_BASEURL
+# customize the polling time of each engine. The default time is 5 seconds
+DB_POLL_INTERVAL_SECONDS = {
+ "hive": int(timedelta(seconds=5).total_seconds()),
+}
Review Comment:
I can restore the previous code without changing this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #22635: fix: Stop query in SQL Lab with impala engine
Posted by GitBox <gi...@apache.org>.
villebro merged PR #22635:
URL: https://github.com/apache/superset/pull/22635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org