You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andreas Köhler (Created JIRA)" <ji...@apache.org> on 2011/11/25 13:07:41 UTC
[jira] [Created] (WICKET-4260) UrlRenderer renders invalid relative
URLs if first segment contains colon
UrlRenderer renders invalid relative URLs if first segment contains colon
-------------------------------------------------------------------------
Key: WICKET-4260
URL: https://issues.apache.org/jira/browse/WICKET-4260
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.3
Reporter: Andreas Köhler
Seen on Wicket 1.5.3.
If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248381#comment-13248381 ]
Sven Meier commented on WICKET-4260:
------------------------------------
>I can pull it and test it
Please do so, thanks.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246328#comment-13246328 ]
Sven Meier commented on WICKET-4260:
------------------------------------
I don't have an IE at hand at the moment, but I tested the ieDotSlashBug application on Tomcat with root context (Root.war).
A redirect to "./logon" was handled differently on Jetty and Tomcat:
- Jetty redirects to "http://localhost:8080/logon", as org.eclipse.jetty.server.Response#sendRedirect() uses a canonical path (i.e. all "." and ".." factored out)
- Tomcat redirects to "http://localhost:8080/./logon", obviously leaving the dot in Wicket's relative url as is.
For reference an excerpt of HttpServletResponse#sendRedirect()'s javadoc:
"... This method can accept relative URLs; the servlet container must convert the relative URL to an absolute URL before sending the response to the client..."
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249135#comment-13249135 ]
Chris Colman commented on WICKET-4260:
--------------------------------------
Yep, works fine now. Thanks!
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246403#comment-13246403 ]
Sven Meier commented on WICKET-4260:
------------------------------------
Could you test whether it works when you mount LandingPage on "nested/landing"?
It seems Tomcat happily redirects to "http://localhost:8080/../logon" - I'd be interested whether IE can handle that.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Andreas Köhler (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158888#comment-13158888 ]
Andreas Köhler commented on WICKET-4260:
----------------------------------------
Yes, I would prefer not to break everything else :) But feel free to patch as you like.
Still, this bug needs fixing, of course, as right now those links do not work at all.
BTW, should not ./foo resolve to /foo when on /bar?
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Igor Vaynberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159015#comment-13159015 ]
Igor Vaynberg commented on WICKET-4260:
---------------------------------------
yes, shouldve been /bar/baz :)
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Martin Grigorov (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-4260:
---------------------------------------
Assignee: Sven Meier
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Attachments: WICKET-4260.diff, WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246320#comment-13246320 ]
Chris Colman commented on WICKET-4260:
--------------------------------------
I'm not sure how many web apps have a colon in the paths but I know (unfortunately) that a lot of corporates are locked into IE and this fix breaks IE under the conditions I outlined above which means some of our significant corporate customers now have a broken app - they need to hit Refresh after logging in to get 'over' the error page.
Is is possible to make this *fix* a configurable one so that those sites that don't have colons in their path can disable the addition of the './' prefix? Or better still, make that the default and sites that want to use a colon in the paths need to explicitly turn it on.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246332#comment-13246332 ]
Sven Meier commented on WICKET-4260:
------------------------------------
>Is is possible to make this *fix* a configurable one
I'd rather not make this configurable.
I'll investigate whether this is a known issue for Tomcat. If there's no fix, we can remove a leading "./" from the url before passing it to HttpServletResponse#sendRedirect().
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4260) UrlRenderer renders invalid relative
URLs if first segment contains colon
Posted by "Sven Meier (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier updated WICKET-4260:
-------------------------------
Attachment: WICKET-4260.diff
Alternative patch.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: WICKET-4260.diff, WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier reopened WICKET-4260:
--------------------------------
need to invesigate IE8 issue
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246679#comment-13246679 ]
Chris Colman commented on WICKET-4260:
--------------------------------------
I've just tested it and found IE works fine with "nested/landing"
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier resolved WICKET-4260.
--------------------------------
Resolution: Fixed
Fix Version/s: (was: 6.0.0-beta1)
6.0.0-RC1
Now working with sendRedirect() for Tomcat+IE too.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-RC1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247750#comment-13247750 ]
Sven Meier commented on WICKET-4260:
------------------------------------
>IE handles "../" but not "./" ... Do you have any ideas on the best approach for fixing this?
Strange, yes.
I'd say we keep this ticket as it is now (i.e. all relative urls prefixed with "./" or "../").
But we'll let ServletWebResponse remove a leading "./" before passing the url to HttpServletRequest#sendRedirect().
This does no harm and as you stated is essential as a workaround for the Tomcat/IE combination.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247675#comment-13247675 ]
Chris Colman commented on WICKET-4260:
--------------------------------------
Seems weird that IE handles "../" but not "./" though it is IE afterall so 'weird' becomes the expectation ;)
Do you have any ideas on the best approach for fixing this? We have temporarily reverted to 1.5.5 to get our site working for IE customers again but obviously some day soon we'll need to be able to upgrade to 1.5.6 or a snapshot.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (WICKET-4260) UrlRenderer renders
invalid relative URLs if first segment contains colon
Posted by "Chris Colman (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246356#comment-13246356 ]
Chris Colman edited comment on WICKET-4260 at 4/4/12 3:25 PM:
--------------------------------------------------------------
Some observations:
Here's the requests that the server sees - both get redirects to the logon page which is correct because the user is not yet authenticated
IE browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /./logon?3 HTTP/1.1" 404 976
FireFox browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /logon?2 HTTP/1.1" 200 1619
This makes me believe that it may not be a Tomcat bug because it works correctly for FireFox and Chrome. It may be that these browsers can handle the ./ and automatically remove it possibly?
was (Author: chrisc):
Some observations:
Here's the requests that the server sees - both get redirects to the logon page which is correct because the user is not yet authenticated
IE browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /./logon?3 HTTP/1.1" 404 976
FireFox browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /logon?2 HTTP/1.1" 200 1619
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225073#comment-13225073 ]
Martin Grigorov commented on WICKET-4260:
-----------------------------------------
The patch looks quite simple. I'm +1 to commit it in 1.5.x/master once 1.5.5 is out so we can have enough time to test it in different browsers before 1.5.6 is out.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: WICKET-4260.diff, WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4260) UrlRenderer renders invalid relative
URLs if first segment contains colon
Posted by "Pedro Santos (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-4260:
---------------------------------
Attachment: WICKET-4260.path
Hi Andreas, it's weird to have the URL renderer behavior differently because of the first segment content. IMO it would be better if we start to always render relative to the base URLs to have the dot slash prepended.
I'm sending your patch back (MyUrlRenderer) with this improvement.
I'm 1+ for this change, if the team agree we can already start to change tests expectations.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (WICKET-4260) UrlRenderer renders
invalid relative URLs if first segment contains colon
Posted by "Chris Colman (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246356#comment-13246356 ]
Chris Colman edited comment on WICKET-4260 at 4/4/12 3:23 PM:
--------------------------------------------------------------
Some observations:
Here's the requests that the server sees - both get redirects to the logon page which is correct because the user is not yet authenticated
IE browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /./logon?3 HTTP/1.1" 404 976
FireFox browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /logon?2 HTTP/1.1" 200 1619
was (Author: chrisc):
Some observations:
Typing URLs containing an intermediate './' (eg., thingy.com.au/./landing) directly into browsers I observed the following:
FireFox and Chrome gets a redirect back from the server to the same URL but with the './' automatically removed - which would explain why they work with Tomcat.
IE gets a redirect back from the server that contains the ./ which the web app does not recognize as a known path and so throws a 404 error.
Here's the requests that the server sees:
IE browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /./logon?3 HTTP/1.1" 404 976
FireFox browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /logon?2 HTTP/1.1" 200 1619
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246356#comment-13246356 ]
Chris Colman commented on WICKET-4260:
--------------------------------------
Some observations:
Typing URLs containing an intermediate './' (eg., thingy.com.au/./landing) directly into browsers I observed the following:
FireFox and Chrome gets a redirect back from the server to the same URL but with the './' automatically removed - which would explain why they work with Tomcat.
IE gets a redirect back from the server that contains the ./ which the web app does not recognize as a known path and so throws a 404 error.
Here's the requests that the server sees:
IE browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:16:13 +1000] "GET /./logon?3 HTTP/1.1" 404 976
FireFox browser requesting /landing
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /landing HTTP/1.1" 302 -
127.0.0.1 - - [05/Apr/2012:01:18:12 +1000] "GET /logon?2 HTTP/1.1" 200 1619
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251581#comment-13251581 ]
Martin Grigorov commented on WICKET-4260:
-----------------------------------------
Filed a bug at Tomcat issue tracker for this problem: https://issues.apache.org/bugzilla/show_bug.cgi?id=53062
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-RC1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier resolved WICKET-4260.
--------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
1.5.6
All relative urls are now explicitely relative, i.e. start with a dot or dot-dot.
Tested with IE, Firefox and Chrome and everything worked as expected (e.g. "./foo" when on "/").
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Sven Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229117#comment-13229117 ]
Sven Meier commented on WICKET-4260:
------------------------------------
Just tested with Safari, works too.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Igor Vaynberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158805#comment-13158805 ]
Igor Vaynberg commented on WICKET-4260:
---------------------------------------
be careful to make sure that it doesnt break anything, in the past it has caused us headaches..
things like
does ./foo resolve to /foo when on "/" and /bar/foo when on "/bar" in all browsers. etc.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Pedro Santos (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159272#comment-13159272 ]
Pedro Santos commented on WICKET-4260:
--------------------------------------
Quoting the RFC 2396 at http://www.ietf.org/rfc/rfc2396.txt
" Authors should be aware that a path segment which contains a colon
character cannot be used as the first segment of a relative URI path
(e.g., "this:that"), because it would be mistaken for a scheme name."
Sounds like it would make sense if we improve the UrlRenderer#shouldRenderAsFull method to return true if the first segment has a colon. Fix this ticket but may break some apps because users may have code expecting relative URLs.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: WICKET-4260.path, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Chris Colman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247924#comment-13247924 ]
Chris Colman commented on WICKET-4260:
--------------------------------------
Sounds like a good solution. If you add a patch to 1.5.x in the git repository I can pull it and test it on both my quickstart and the real app whenever you're ready.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4260) UrlRenderer renders invalid relative
URLs if first segment contains colon
Posted by "Chris Colman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Colman updated WICKET-4260:
---------------------------------
Attachment: ieDotSlashBug.zip
Quickstart that shows IE problem with extra ./ inserted before path when /landing page is redirected to /logon page if not authenticated.
Happens on IE 8 (and possibly other IE versions)
Does not happen on FireFox nor Chrome.
Does not happen when running on Jetty
Happens on Tomcat BUT only when app is installed as a virtual host - it does not happen when the app is installed as a servlet in the root context/host.
Using the quickstart create a .war using mvn war:war
Create an entry in your hosts file:
127.0.0.1 thingy.com.au
Rename the .war to ROOT.war and place under:
<tomcat>/virtualhosts/thingy
Add new host element to server.xml:
<Host name="thingy.com.au" debug="0" appBase="virtualhosts/thingy" unpackWARs="true" autoDeploy="true" xmlValidation="false" xmlNamespaceAware="false">
<Valve className="org.apache.catalina.valves.FastCommonAccessLogValve"
directory="logs" prefix="thing_access_log." suffix=".txt"
pattern="common" resolveHosts="false"/>
<Context path="/manager" debug="5" docBase="/servers/tomcat/webapps/manager" privileged="true"/>
</Host>
To reproduce:
Point your IE browser to:
http://thingy.com.au/landing
this will attempt a redirect to thingy.com.au/logon
which should display the error.
Hit refresh and the logon page will display. Click on Logon link and problem should display again. Hit refresh and landing page will now display properly.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4260) UrlRenderer renders invalid
relative URLs if first segment contains colon
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246203#comment-13246203 ]
Martin Grigorov commented on WICKET-4260:
-----------------------------------------
This change also exposed a bug in Jetty 7.6.2 and earlier: https://bugs.eclipse.org/bugs/show_bug.cgi?id=374475
Basically the redirect will fail if it contains non-ASCII chars.
The fix will be in Jetty 7.6.3.
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Assignee: Sven Meier
> Fix For: 1.5.6, 6.0.0-beta1
>
> Attachments: WICKET-4260.diff, WICKET-4260.path, ieDotSlashBug.zip, wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4260) UrlRenderer renders invalid relative
URLs if first segment contains colon
Posted by "Andreas Köhler (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Köhler updated WICKET-4260:
-----------------------------------
Attachment: wicket-4260.tar.bz2
Quickstart
> UrlRenderer renders invalid relative URLs if first segment contains colon
> -------------------------------------------------------------------------
>
> Key: WICKET-4260
> URL: https://issues.apache.org/jira/browse/WICKET-4260
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.3
> Reporter: Andreas Köhler
> Attachments: wicket-4260.tar.bz2
>
>
> Seen on Wicket 1.5.3.
> If a relative url of a link starts with a path segment containing a colon then the whole uri will be regarded as absolute uri, so typically browsers will complain that there is no handle for the protocol foo in foo:bar/dee/per.
> See also the attached quickstart. The start page contains three links, one relative with colon, one absolute and one to a mounted page without colon for comparison.
> The application also has a static switch to add an extended urlrenderer, prepending "./" if needed. This fix is merely a quick shot and there might be better alternatives.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira