You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/10/15 23:48:00 UTC

[GitHub] [royale-asjs] mjesteve opened a new issue #921: Jewel ArrayListSelectionModel, selectedItem

mjesteve opened a new issue #921:
URL: https://github.com/apache/royale-asjs/issues/921


   Hi,
   I think I have encountered an error in the selectedItem setter in Jewel ArrayListSelectionModel.
   Before the re-selection of an element, same item, "selectionChanged" is always thrown because it is understood that the existing selectedIndex is different from the current one, even though it is not because there is a copy-paste error in the setter:
   
   ![image](https://user-images.githubusercontent.com/55754195/96197032-2efc8200-0f51-11eb-8281-45e49e68dcab.png)
   
   ¿Podría ser?
   
   ![image](https://user-images.githubusercontent.com/55754195/96197162-8a2e7480-0f51-11eb-8207-9f660cf74c45.png)
   
   Thx.
   Hiedra.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] carlosrovira commented on issue #921: Jewel ArrayListSelectionModel, selectedItem

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #921:
URL: https://github.com/apache/royale-asjs/issues/921#issuecomment-711300294


   Since Greg already check this and seems to be ok I'll close this issue
   
   (comments from greg here: https://github.com/apache/royale-asjs/commit/edc132ccf214c381703c816fa90f23e179c993c4)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [GitHub] [royale-asjs] carlosrovira commented on issue #921: Jewel ArrayListSelectionModel, selectedItem

Posted by Greg Dove <gr...@gmail.com>.
Sorry I don't think that's a typo. Maybe it's not the most readable code
but i think the event should only happen if selected Index changed. Will
verify when I officially wake up (because I am supposed to be asleep right
now)

On Fri, 16 Oct 2020, 22:48 GitBox, <gi...@apache.org> wrote:

>
> carlosrovira commented on issue #921:
> URL:
> https://github.com/apache/royale-asjs/issues/921#issuecomment-709945317
>
>
>    Hi @mjesteve, I think you're right.
>    @greg-dove I'm going to make this change, but if that's not a typo and
> have a motivation behind that we're not seeing please revert it.
>    Thanks both! :)
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>

[GitHub] [royale-asjs] carlosrovira commented on issue #921: Jewel ArrayListSelectionModel, selectedItem

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #921:
URL: https://github.com/apache/royale-asjs/issues/921#issuecomment-709945317


   Hi @mjesteve, I think you're right.
   @greg-dove I'm going to make this change, but if that's not a typo and have a motivation behind that we're not seeing please revert it.
   Thanks both! :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] carlosrovira closed issue #921: Jewel ArrayListSelectionModel, selectedItem

Posted by GitBox <gi...@apache.org>.
carlosrovira closed issue #921:
URL: https://github.com/apache/royale-asjs/issues/921


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] carlosrovira closed issue #921: Jewel ArrayListSelectionModel, selectedItem

Posted by GitBox <gi...@apache.org>.
carlosrovira closed issue #921:
URL: https://github.com/apache/royale-asjs/issues/921


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [royale-asjs] carlosrovira commented on issue #921: Jewel ArrayListSelectionModel, selectedItem

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on issue #921:
URL: https://github.com/apache/royale-asjs/issues/921#issuecomment-711172601


   Hi @greg-dove 
   
   since you responded:
   
   > Sorry I don't think that's a typo. Maybe it's not the most readable code
   but i think the event should only happen if selected Index changed. Will
   verify when I officially wake up (because I am supposed to be asleep right
   now)
   
   I reverted the commit and left this issue open awaiting for your thoughts
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org