You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/04/03 19:22:30 UTC
Review Request 66411: Made the test CSI plugin compatible to CSI v0.2.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66411/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717
Repository: mesos
Description
-------
This patch contains necessary changes for the test CSI plugin to support
CSI v0.2. The `STAGE_UNSTAGE_VOLUME` node service capability is not
implemented in this patch yet.
Diffs
-----
src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19
src/tests/storage_local_resource_provider_tests.cpp 2872f1aec1a7b94fc302a533f5ae9e1be9658087
Diff: https://reviews.apache.org/r/66411/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 66411: Made the test CSI plugin compatible to CSI
v0.2.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66411/#review201026
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 11, 2018, 2:36 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66411/
> -----------------------------------------------------------
>
> (Updated April 11, 2018, 2:36 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8717
> https://issues.apache.org/jira/browse/MESOS-8717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch contains necessary changes for the test CSI plugin to support
> CSI v0.2. The `STAGE_UNSTAGE_VOLUME` node service capability is not
> implemented in this patch yet.
>
>
> Diffs
> -----
>
> src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19
>
>
> Diff: https://reviews.apache.org/r/66411/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66411: Made the test CSI plugin compatible to CSI
v0.2.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66411/
-----------------------------------------------------------
(Updated April 11, 2018, 2:36 a.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Fixed a bug that made `DeleteVolume` nonidempotent.
Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717
Repository: mesos
Description
-------
This patch contains necessary changes for the test CSI plugin to support
CSI v0.2. The `STAGE_UNSTAGE_VOLUME` node service capability is not
implemented in this patch yet.
Diffs (updated)
-----
src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19
Diff: https://reviews.apache.org/r/66411/diff/3/
Changes: https://reviews.apache.org/r/66411/diff/2-3/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 66411: Made the test CSI plugin compatible to CSI
v0.2.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66411/
-----------------------------------------------------------
(Updated April 4, 2018, 4 a.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717
Repository: mesos
Description
-------
This patch contains necessary changes for the test CSI plugin to support
CSI v0.2. The `STAGE_UNSTAGE_VOLUME` node service capability is not
implemented in this patch yet.
Diffs (updated)
-----
src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19
Diff: https://reviews.apache.org/r/66411/diff/2/
Changes: https://reviews.apache.org/r/66411/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 66411: Made the test CSI plugin compatible to CSI
v0.2.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66411/#review200395
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66398.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66398`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66411
Relevant logs:
- [apply-review-66398-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66411/logs/apply-review-66398-stdout.log):
```
error: missing binary patch data for '3rdparty/csi-0.2.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.2.0.tar.gz'
error: 3rdparty/csi-0.2.0.tar.gz: patch does not apply
```
- Mesos Reviewbot Windows
On April 3, 2018, 7:22 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66411/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 7:22 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8717
> https://issues.apache.org/jira/browse/MESOS-8717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch contains necessary changes for the test CSI plugin to support
> CSI v0.2. The `STAGE_UNSTAGE_VOLUME` node service capability is not
> implemented in this patch yet.
>
>
> Diffs
> -----
>
> src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19
> src/tests/storage_local_resource_provider_tests.cpp 2872f1aec1a7b94fc302a533f5ae9e1be9658087
>
>
> Diff: https://reviews.apache.org/r/66411/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 66411: Made the test CSI plugin compatible to CSI
v0.2.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66411/#review200400
-----------------------------------------------------------
Bad patch!
Reviews applied: [66411, 66410, 66409, 66408, 66407, 66398]
Failed command: python support/apply-reviews.py -n -r 66398
Error:
2018-04-03 20:40:02 URL:https://reviews.apache.org/r/66398/diff/raw/ [1889/1889] -> "66398.patch" [1]
error: missing binary patch data for '3rdparty/csi-0.2.0.tar.gz'
error: binary patch does not apply to '3rdparty/csi-0.2.0.tar.gz'
error: 3rdparty/csi-0.2.0.tar.gz: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/22086/console
- Mesos Reviewbot
On April 3, 2018, 9:22 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66411/
> -----------------------------------------------------------
>
> (Updated April 3, 2018, 9:22 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8717
> https://issues.apache.org/jira/browse/MESOS-8717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch contains necessary changes for the test CSI plugin to support
> CSI v0.2. The `STAGE_UNSTAGE_VOLUME` node service capability is not
> implemented in this patch yet.
>
>
> Diffs
> -----
>
> src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19
> src/tests/storage_local_resource_provider_tests.cpp 2872f1aec1a7b94fc302a533f5ae9e1be9658087
>
>
> Diff: https://reviews.apache.org/r/66411/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>