[GitHub] [iceberg] rdblue commented on a diff in pull request #5051: Build: Quicker project evaluation + write evaluated project version to `build/`

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5051:
URL: https://github.com/apache/iceberg/pull/5051#discussion_r910170788


##########
build.gradle:
##########
@@ -60,9 +60,14 @@ dependencyRecommendations {
   propertiesFile file: file('versions.props')
 }
 
+def projectVersion = getProjectVersion()
+
+buildDir.mkdirs()
+file("$buildDir/version.txt").text = projectVersion

Review Comment:
   I don't think this should create the version.txt file. We only want to create that when setting the version for a release. Otherwise, when it is kept around it will affect future builds, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org