You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2015/10/11 19:02:05 UTC
[jira] [Commented] (YETUS-54) Add Yetus parent POM and top-level
POM
[ https://issues.apache.org/jira/browse/YETUS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952341#comment-14952341 ]
Allen Wittenauer commented on YETUS-54:
---------------------------------------
I'm +1, but I can't help but think that we might be doing a disservice by not setting the jdk version to be [1.7,), given that we're very likely to be used by jdk 1.9 sooner rather than later.
> Add Yetus parent POM and top-level POM
> --------------------------------------
>
> Key: YETUS-54
> URL: https://issues.apache.org/jira/browse/YETUS-54
> Project: Yetus
> Issue Type: Task
> Components: Audience Annotations, build
> Affects Versions: 0.1.0
> Reporter: Andrew Bayer
> Assignee: Sean Busbey
> Attachments: YETUS-54.1.patch
>
>
> So at least for as long as we're using Maven, I'd strongly advise that we not have audience-annotations inherit from hadoop-common's parent POM and instead inherit from a Yetus parent POM. I'd also advise that we follow the same kind of split that Hadoop has, with a yetus-parent POM in a subdirectory, separate from a top-level POM in the root directory. Parent POMs are great for defining things to inherit (versions, dependencies, properties, SCM info, etc) but are crap for aggregation once you try to do things like site generation, javadoc, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Commented] (YETUS-54) Add Yetus parent POM and top-level POM
Posted by Sean Busbey <se...@gmail.com>.
I had considered doing that, but wasn't sure if we'd need to have some
older compat around. FWIW I think our current annotation code itself will
work with 1.5+, even though our POM is only prepared for 1.7 and 1.8.
Could still make the project default and then specialize for annotations?
Or just document instructions for folks that need pre-jdk7...
On Oct 11, 2015 12:02 PM, "Allen Wittenauer (JIRA)" <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/YETUS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952341#comment-14952341
> ]
>
> Allen Wittenauer commented on YETUS-54:
> ---------------------------------------
>
> I'm +1, but I can't help but think that we might be doing a disservice by
> not setting the jdk version to be [1.7,), given that we're very likely to
> be used by jdk 1.9 sooner rather than later.
>
>
> > Add Yetus parent POM and top-level POM
> > --------------------------------------
> >
> > Key: YETUS-54
> > URL: https://issues.apache.org/jira/browse/YETUS-54
> > Project: Yetus
> > Issue Type: Task
> > Components: Audience Annotations, build
> > Affects Versions: 0.1.0
> > Reporter: Andrew Bayer
> > Assignee: Sean Busbey
> > Attachments: YETUS-54.1.patch
> >
> >
> > So at least for as long as we're using Maven, I'd strongly advise that
> we not have audience-annotations inherit from hadoop-common's parent POM
> and instead inherit from a Yetus parent POM. I'd also advise that we follow
> the same kind of split that Hadoop has, with a yetus-parent POM in a
> subdirectory, separate from a top-level POM in the root directory. Parent
> POMs are great for defining things to inherit (versions, dependencies,
> properties, SCM info, etc) but are crap for aggregation once you try to do
> things like site generation, javadoc, etc.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>