[GitHub] lburgazzoli commented on a change in pull request #350: fix openapi handling when used in conjunction with deployment.container-image=true

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #350: fix openapi handling when used in conjunction with deployment.container-image=true
URL: https://github.com/apache/camel-k/pull/350#discussion_r249461664
 
 

 ##########
 File path: pkg/platform/platform.go
 ##########
 @@ -32,12 +32,12 @@ import (
 var gBuilder builder.Builder
 
 // GetPlatformBuilder --
-func GetPlatformBuilder(ctx context.Context, c client.Client, namespace string) (builder.Builder, error) {
+func GetPlatformBuilder(c client.Client, namespace string) (builder.Builder, error) {
 	if gBuilder != nil {
 		return gBuilder, nil
 	}
 
-	gBuilder = builder.New(ctx, c, namespace)
+	gBuilder = builder.New(context.TODO(), c, namespace)
 
 Review comment:
   The problem is that the builder is created once per platform so if we use the context of the caller, it will be the one of the first caller and it can be closed which causes the builder to stop.
   
   I need to think about a better solution but in a separate pr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services