You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by deki <gi...@git.apache.org> on 2017/03/21 13:25:44 UTC
[GitHub] cxf pull request #247: CXF-7291: sharedPackageName for Swagger desc should i...
GitHub user deki opened a pull request:
https://github.com/apache/cxf/pull/247
CXF-7291: sharedPackageName for Swagger desc should ignore proxys
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/deki/cxf CXF-7291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #247
----
commit 35dc8302065eaabff2488976943002364beebb30
Author: Dennis Kieselhorst <ma...@dekies.de>
Date: 2017-03-21T13:23:45Z
CXF-7291: sharedPackageName for Swagger description should ignore proxy classes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #247: CXF-7291: sharedPackageName for Swagger desc should i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cxf/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #247: CXF-7291: sharedPackageName for Swagger desc should ignore p...
Posted by sberyozkin <gi...@git.apache.org>.
Github user sberyozkin commented on the issue:
https://github.com/apache/cxf/pull/247
Hi Dennis, is it related to the client proxy thing ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #247: CXF-7291: sharedPackageName for Swagger desc should i...
Posted by reta <gi...@git.apache.org>.
Github user reta commented on a diff in the pull request:
https://github.com/apache/cxf/pull/247#discussion_r107218893
--- Diff: core/src/main/java/org/apache/cxf/common/util/PackageUtils.java ---
@@ -56,7 +57,9 @@ public static String getSharedPackageName(List<Class<?>> classes) {
List<List<String>> lParts = new ArrayList<List<String>>(classes.size());
List<String> currentParts = new ArrayList<>();
for (Class<?> cls : classes) {
- lParts.add(StringUtils.getParts(getPackageName(cls), "\\."));
+ if (!Proxy.isProxyClass(cls)) {
--- End diff --
In this case, should we get the real class using `getProxyClass` and extract the package from it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #247: CXF-7291: sharedPackageName for Swagger desc should ignore p...
Posted by deki <gi...@git.apache.org>.
Github user deki commented on the issue:
https://github.com/apache/cxf/pull/247
yes but in my view this should be fixed in any case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #247: CXF-7291: sharedPackageName for Swagger desc should i...
Posted by deki <gi...@git.apache.org>.
Github user deki commented on a diff in the pull request:
https://github.com/apache/cxf/pull/247#discussion_r107344997
--- Diff: core/src/main/java/org/apache/cxf/common/util/PackageUtils.java ---
@@ -56,7 +57,9 @@ public static String getSharedPackageName(List<Class<?>> classes) {
List<List<String>> lParts = new ArrayList<List<String>>(classes.size());
List<String> currentParts = new ArrayList<>();
for (Class<?> cls : classes) {
- lParts.add(StringUtils.getParts(getPackageName(cls), "\\."));
+ if (!Proxy.isProxyClass(cls)) {
--- End diff --
Good idea, I first thought to use InvocationHandler stuff for this but in the method only the class itself is available. And afaik it's not possible to get the real class as there might be multiple interfaces...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---