You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/29 22:35:41 UTC

[GitHub] [airflow] dimon222 edited a comment on pull request #19726: Fix Volume/VolumeMount KPO DeprecationWarning

dimon222 edited a comment on pull request #19726:
URL: https://github.com/apache/airflow/pull/19726#issuecomment-982085070


   @jedcunningham  this is where stuff might  get sketchy.
   I can apply those corrections, but because of inconsistency of current implementation, there will be.. corner case scenarios.
   
   Specifically for Pod, Resources and PodRuntimeInfoEnv I don't see deprecation warnings for classes - I can add them, same as we do for others. However, the Resources logic even goes further by doing blind conversion without letting anyone know.
   https://github.com/apache/airflow/blob/7b03678ec557a23017a6aa1fc225bbc84e5a92fb/airflow/providers/cncf/kubernetes/backcompat/backwards_compat_converters.py#L75-L76


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org