You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/07/31 02:40:22 UTC
Review Request 68120: UI: Pull up the leader URL generation to a
top-level function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68120/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Gastón Kleiman.
Repository: mesos
Description
-------
This path pulls up the leader URL prefix generation to a top-level
function in order to have it re-used across controllers.
Having this logic in just one place makes it easier to modify it,
e.g., to make it possible to use the UI via a reverse proxy.
Diffs
-----
src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b
src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc
Diff: https://reviews.apache.org/r/68120/diff/1/
Testing
-------
manual testing
Thanks,
Benjamin Mahler
Re: Review Request 68120: UI: Pull up the leader URL generation to a
top-level function.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68120/#review206652
-----------------------------------------------------------
src/webui/app/controllers.js
Lines 515 (patched)
<https://reviews.apache.org/r/68120/#comment289721>
This is the first time we use a ternary operator in this file but we use some in `app.js` and it makes sense to use it here.
- Armand Grillet
On July 31, 2018, 2:40 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68120/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 2:40 a.m.)
>
>
> Review request for mesos, Armand Grillet and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This path pulls up the leader URL prefix generation to a top-level
> function in order to have it re-used across controllers.
>
> Having this logic in just one place makes it easier to modify it,
> e.g., to make it possible to use the UI via a reverse proxy.
>
>
> Diffs
> -----
>
> src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b
> src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc
>
>
> Diff: https://reviews.apache.org/r/68120/diff/1/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68120: UI: Pull up the leader URL generation to a
top-level function.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68120/#review206639
-----------------------------------------------------------
PASS: Mesos patch 68120 was successfully built and tested.
Reviews applied: `['68120']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2007/mesos-review-68120
- Mesos Reviewbot Windows
On July 31, 2018, 2:40 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68120/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 2:40 a.m.)
>
>
> Review request for mesos, Armand Grillet and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This path pulls up the leader URL prefix generation to a top-level
> function in order to have it re-used across controllers.
>
> Having this logic in just one place makes it easier to modify it,
> e.g., to make it possible to use the UI via a reverse proxy.
>
>
> Diffs
> -----
>
> src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b
> src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc
>
>
> Diff: https://reviews.apache.org/r/68120/diff/1/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68120: UI: Pull up the leader URL generation to a
top-level function.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68120/#review206653
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On July 31, 2018, 2:40 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68120/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 2:40 a.m.)
>
>
> Review request for mesos, Armand Grillet and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This path pulls up the leader URL prefix generation to a top-level
> function in order to have it re-used across controllers.
>
> Having this logic in just one place makes it easier to modify it,
> e.g., to make it possible to use the UI via a reverse proxy.
>
>
> Diffs
> -----
>
> src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b
> src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc
>
>
> Diff: https://reviews.apache.org/r/68120/diff/1/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68120: UI: Pull up the leader URL generation to a
top-level function.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68120/#review206685
-----------------------------------------------------------
PASS: Mesos patch 68120 was successfully built and tested.
Reviews applied: `['68120']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2014/mesos-review-68120
- Mesos Reviewbot Windows
On July 31, 2018, 7:26 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68120/
> -----------------------------------------------------------
>
> (Updated July 31, 2018, 7:26 p.m.)
>
>
> Review request for mesos, Armand Grillet and Gastón Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This path pulls up the leader URL prefix generation to a top-level
> function in order to have it re-used across controllers.
>
> This also ensures that everything shown is consistently coming
> from the leading master, specifically, now the log viewer shows
> the leading master's log (and the UI messaging is updated in this
> patch accordingly).
>
> Having this logic in just one place makes it easier to modify it,
> e.g., to make it possible to use the UI via a reverse proxy.
>
>
> Diffs
> -----
>
> src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b
> src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc
>
>
> Diff: https://reviews.apache.org/r/68120/diff/2/
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68120: UI: Pull up the leader URL generation to a
top-level function.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68120/
-----------------------------------------------------------
(Updated July 31, 2018, 7:26 p.m.)
Review request for mesos, Armand Grillet and Gastón Kleiman.
Changes
-------
Updated the html to indicate that the log viewer is pointing to the leading master's log.
Repository: mesos
Description (updated)
-------
This path pulls up the leader URL prefix generation to a top-level
function in order to have it re-used across controllers.
This also ensures that everything shown is consistently coming
from the leading master, specifically, now the log viewer shows
the leading master's log (and the UI messaging is updated in this
patch accordingly).
Having this logic in just one place makes it easier to modify it,
e.g., to make it possible to use the UI via a reverse proxy.
Diffs (updated)
-----
src/webui/app/controllers.js 7c228a1629d7b1dcce56b432f042f02d3ec1583b
src/webui/app/home.html ff965952d7a8d84c9dcf5555d5d6e7e045cd72bc
Diff: https://reviews.apache.org/r/68120/diff/2/
Changes: https://reviews.apache.org/r/68120/diff/1-2/
Testing
-------
manual testing
Thanks,
Benjamin Mahler