You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/05/24 20:07:27 UTC
(texera) branch gh-readonly-queue/main/pr-5181-b228d5186e52a5009ff7de987adf2cf204482f89 created (now afb29e7502)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-5181-b228d5186e52a5009ff7de987adf2cf204482f89
in repository https://gitbox.apache.org/repos/asf/texera.git
at afb29e7502 test(frontend): call fixture.detectChanges() in three dashboard component specs (#5181)
This branch includes the following new commits:
new afb29e7502 test(frontend): call fixture.detectChanges() in three dashboard component specs (#5181)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(texera) 01/01: test(frontend): call fixture.detectChanges() in three dashboard component specs (#5181)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-5181-b228d5186e52a5009ff7de987adf2cf204482f89
in repository https://gitbox.apache.org/repos/asf/texera.git
commit afb29e75029eb5ac2debb7981418772f9ed0741e
Author: Yicong Huang <17...@users.noreply.github.com>
AuthorDate: Sun May 24 13:07:05 2026 -0700
test(frontend): call fixture.detectChanges() in three dashboard component specs (#5181)
### What changes were proposed in this PR?
`list-item`, `share-access`, and `user-dataset-file-renderer` each
constructed a `ComponentFixture` via `TestBed.createComponent` but never
triggered change detection. The template's creation pass therefore never
ran, the source-map-attributed v8 coverage stayed at 0 % for the
corresponding `.component.html`, and the specs still passed green.
Adds `fixture.detectChanges()` to each:
- `list-item.component.spec.ts` — seeds `component.entry` with a
fully-formed workflow entry in `beforeEach` before calling
`detectChanges()`. The component's `entry` getter throws when `_entry`
is undefined and `initializeEntry()` (called from `ngOnChanges`) reads
`entry.workflow.isOwner`, `accessibleUserIds`, and counters, so a
minimal stub is not enough. Each `it` block continues to overwrite
`component.entry` and assert on confirm-method behavior; no existing
assertions change.
- `share-access.component.spec.ts` — `detectChanges()` lives in the
`setupComponent` helper so every test case picks it up.
- `user-dataset-file-renderer.component.spec.ts` — `detectChanges()` in
`beforeEach` after `createComponent`. `ngOnInit -> reloadFileContent`
hits the unsupported-MIME bail with the default empty `filePath`, so no
service calls fire.
### Any related issues, documentation, discussions?
Closes #5180.
### How was this PR tested?
`yarn ng test --watch=false --include=…` against the three affected
specs locally: 3 files, 10 tests, all pass. `yarn format:ci` clean.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
---
.../user/list-item/list-item.component.spec.ts | 17 +++++++++++++++++
.../user/share-access/share-access.component.spec.ts | 4 +++-
.../user-dataset-file-renderer.component.spec.ts | 1 +
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/frontend/src/app/dashboard/component/user/list-item/list-item.component.spec.ts b/frontend/src/app/dashboard/component/user/list-item/list-item.component.spec.ts
index debcc5b99e..c00d509868 100644
--- a/frontend/src/app/dashboard/component/user/list-item/list-item.component.spec.ts
+++ b/frontend/src/app/dashboard/component/user/list-item/list-item.component.spec.ts
@@ -53,6 +53,23 @@ describe("ListItemComponent", () => {
fixture = TestBed.createComponent(ListItemComponent);
component = fixture.componentInstance;
workflowPersistService = TestBed.inject(WorkflowPersistService) as unknown as Mocked<WorkflowPersistService>;
+ // initializeEntry() needs a fully-formed workflow entry to avoid throwing
+ // when the template renders for the first time. Each test below overwrites
+ // component.entry directly, which exercises confirm methods without going
+ // back through change detection.
+ component.entry = {
+ id: 0,
+ name: "default",
+ description: "",
+ type: "workflow",
+ workflow: { isOwner: true },
+ accessibleUserIds: [],
+ likeCount: 0,
+ viewCount: 0,
+ isLiked: false,
+ size: 0,
+ } as unknown as DashboardEntry;
+ fixture.detectChanges();
});
it("should update workflow name successfully", () => {
diff --git a/frontend/src/app/dashboard/component/user/share-access/share-access.component.spec.ts b/frontend/src/app/dashboard/component/user/share-access/share-access.component.spec.ts
index b5c525956e..9227790988 100644
--- a/frontend/src/app/dashboard/component/user/share-access/share-access.component.spec.ts
+++ b/frontend/src/app/dashboard/component/user/share-access/share-access.component.spec.ts
@@ -70,7 +70,9 @@ describe("ShareAccessComponent.grantAccess", () => {
{ provide: WorkflowActionService, useValue: {} },
],
});
- return TestBed.createComponent(ShareAccessComponent).componentInstance;
+ const fixture = TestBed.createComponent(ShareAccessComponent);
+ fixture.detectChanges();
+ return fixture.componentInstance;
}
beforeEach(() => {
diff --git a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.spec.ts b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.spec.ts
index 9e70a444df..6d61e05a88 100644
--- a/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.spec.ts
+++ b/frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.spec.ts
@@ -40,6 +40,7 @@ describe("UserDatasetFileRendererComponent", () => {
});
const fixture = TestBed.createComponent(UserDatasetFileRendererComponent);
component = fixture.componentInstance;
+ fixture.detectChanges();
});
it("should return true for supported MIME type", () => {