You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/11 01:23:32 UTC

[GitHub] [beam] robertwb commented on a change in pull request #11963: Add relational GroupBy transform to Python.

robertwb commented on a change in pull request #11963:
URL: https://github.com/apache/beam/pull/11963#discussion_r453137842



##########
File path: sdks/python/apache_beam/typehints/native_type_compatibility.py
##########
@@ -85,7 +85,7 @@ def _safe_issubclass(derived, parent):
   """
   try:
     return issubclass(derived, parent)
-  except TypeError:
+  except (TypeError, AttributeError):

Review comment:
       I'm pretty sure I did see this. (Maybe it was missing `__mro__` or something?)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org