You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/28 14:34:47 UTC
[GitHub] [iotdb] BUAAserein opened a new pull request, #8648: [IOTDB-5284] Fix some code smells
BUAAserein opened a new pull request, #8648:
URL: https://github.com/apache/iotdb/pull/8648
## Description
### Fix some code smells, please see in [JIRA5284](https://issues.apache.org/jira/browse/IOTDB-5284)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8648: [IOTDB-5284] Fix some code smells
Posted by GitBox <gi...@apache.org>.
BUAAserein commented on code in PR #8648:
URL: https://github.com/apache/iotdb/pull/8648#discussion_r1058976429
##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java:
##########
@@ -95,7 +95,9 @@ public class ClusterSchemaInfo implements SnapshotProcessor {
private final ReentrantReadWriteLock storageGroupReadWriteLock;
private final ConfigMTree mTree;
- private final String snapshotFileName = "cluster_schema.bin";
+ private static String snapshotFileName = "cluster_schema.bin";
+
+ private final String ERROR_NAME = "Error StorageGroup name";
Review Comment:
Yes, I will fix this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SpriCoder commented on a diff in pull request #8648: [IOTDB-5284] Fix some code smells
Posted by GitBox <gi...@apache.org>.
SpriCoder commented on code in PR #8648:
URL: https://github.com/apache/iotdb/pull/8648#discussion_r1058859690
##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java:
##########
@@ -95,7 +95,9 @@ public class ClusterSchemaInfo implements SnapshotProcessor {
private final ReentrantReadWriteLock storageGroupReadWriteLock;
private final ConfigMTree mTree;
- private final String snapshotFileName = "cluster_schema.bin";
+ private static String snapshotFileName = "cluster_schema.bin";
+
+ private final String ERROR_NAME = "Error StorageGroup name";
Review Comment:
Maybe this one can be static final?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8648: [IOTDB-5284] Fix some code smells
Posted by GitBox <gi...@apache.org>.
OneSizeFitsQuorum merged PR #8648:
URL: https://github.com/apache/iotdb/pull/8648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] BUAAserein commented on a diff in pull request #8648: [IOTDB-5284] Fix some code smells
Posted by GitBox <gi...@apache.org>.
BUAAserein commented on code in PR #8648:
URL: https://github.com/apache/iotdb/pull/8648#discussion_r1058986624
##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java:
##########
@@ -95,7 +95,9 @@ public class ClusterSchemaInfo implements SnapshotProcessor {
private final ReentrantReadWriteLock storageGroupReadWriteLock;
private final ConfigMTree mTree;
- private final String snapshotFileName = "cluster_schema.bin";
+ private static String snapshotFileName = "cluster_schema.bin";
+
+ private final String ERROR_NAME = "Error StorageGroup name";
Review Comment:
Already fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org