You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/12 00:19:27 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new issue #5633: `go vet`: composite literal uses unkeyed fields
zrhoffman opened a new issue #5633:
URL: https://github.com/apache/trafficcontrol/issues/5633
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Grove
- Traffic Ops
- Traffic Ops ORT
## Current behavior:
<!-- Describe how the bug manifests -->
`go vet -composites=true ./...` finds 1,356 issues:
<table><thead><th>Message</th><th>Line of code</th></thead><tbody>
<tr><td><code>database/sql.NullInt64 composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/api/api.go#L712
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/grove/cachedata.ReqData composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/grove/cache/handler.go#L202
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/grove/cachedata.RespData composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/grove/cache/responder.go#L103
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/grove/cachedata.SrvrData composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/grove/cache/handler.go#L168
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-rfc.EmailAddress composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (8 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.Alert composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (19 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.Alerts composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (18 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.ASNsV11 composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/asn/asns.go#L181
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.AssignedDsResponse composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/server/servers_assignment.go#L202
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.DeliveryServiceServerResponse composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go#L276
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.DeliveryServiceServers composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go#L563
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.DSServer composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/deliveryservice/servers/servers_test.go#L197
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.DSServerV4 composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/deliveryservice/eligible_test.go#L162
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.DSSMapResponse composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go#L486
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/lib/go-tc.ServerDetailV40 composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/server/detail_test.go#L172
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/testing/api/v1/config.NegativeTest composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (37 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/testing/api/v1/config.PositiveTest composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (21 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api.APIInfoImpl composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (23 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api.KeyFieldInfo composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (30 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api.Version composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (1048 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/dbhelpers.WhereColumnInfo composite literal uses unkeyed fields</code></td><td>
<details><summary>Click to expand (136 lines)</summary>
</details>
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/parameter.TOParameter composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/monitoring/monitoring_test.go#L805-L806
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/profileparameter.TOProfileParameter composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/profile/copy.go#L144
</td></tr>
<tr><td><code>github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/routing/middleware.AuthBase composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/traffic_ops/traffic_ops_golang/routing/routing_test.go#L207
</td></tr>
<tr><td><code>github.com/miekg/dns.Question composite literal uses unkeyed fields</code></td><td>
https://github.com/apache/trafficcontrol/blob/878b157cfae70116cfa08d10913bc359827ea0f9/test/router/dnssec/dnssec.go#L60
</td></tr>
</tbody></table>
## Expected behavior:
<!-- Describe what the behavior would be without the bug -->
`go vet -composites=true ./...` should find 0 issues.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
include the applicable TC version.
-->
```shell
go vet -composites=true ./...
```
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 closed issue #5633: `go vet`: composite literal uses unkeyed fields
Posted by GitBox <gi...@apache.org>.
mitchell852 closed issue #5633:
URL: https://github.com/apache/trafficcontrol/issues/5633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org