You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/03/18 02:25:06 UTC

[GitHub] [helix] rabashizade commented on pull request #1663: Track failures for async read/write in ZkClient

rabashizade commented on pull request #1663:
URL: https://github.com/apache/helix/pull/1663#issuecomment-801567567


   This PR is ready to be merged, approved by @zhangmeng916.
   
   Commit message:
   
   Track failures for async read/write in ZkClient
   
   Defines separate metrics for async (batch) operations and tracks failure count by checking for operation return code in ZkAsyncCallbacks. Also, cancels async get/exists/delete callbacks when an exception is thrown to be able to detect failure and record the metric. Finally, in TestRawZkClient sync read metrics were used to check async reads, which is fixed to reflect the separation of sync and async metrics.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org