You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "metesynnada (via GitHub)" <gi...@apache.org> on 2023/03/15 07:32:24 UTC
[GitHub] [arrow-rs] metesynnada opened a new pull request, #3868: Supporting metadata fetch without open file read mode
metesynnada opened a new pull request, #3868:
URL: https://github.com/apache/arrow-rs/pull/3868
# Which issue does this PR close?
Did not open an issue since it is a basic enhancement.
# Rationale for this change
It is possible to retrieve metadata without opening the file, which means that FIFO files can also be supported without any additional effort.
# What changes are included in this PR?
`std::file::metadata()` converted into `std::fs::metadata(file_path)`. A test is added for a dummy FIFO file since opening a FIFO file is blocking.
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #3868: Supporting metadata fetch without open file read mode
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #3868:
URL: https://github.com/apache/arrow-rs/pull/3868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3868: Supporting metadata fetch without open file read mode
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3868:
URL: https://github.com/apache/arrow-rs/pull/3868#discussion_r1136884837
##########
object_store/Cargo.toml:
##########
@@ -62,6 +62,9 @@ tokio = { version = "1.25.0", features = ["sync", "macros", "rt", "time", "io-ut
[target.'cfg(target_arch = "wasm32")'.dependencies]
tokio = { version = "1.25.0", features = ["sync", "macros", "rt", "time", "io-util"] }
+[target.'cfg(not(target_os = "windows"))'.dev-dependencies]
Review Comment:
```suggestion
[target.'cfg(target_family="unix")'.dev-dependencies]
```
##########
object_store/src/local.rs:
##########
@@ -1442,3 +1449,29 @@ mod not_wasm_tests {
assert_eq!(&*read_data, expected_data);
}
}
+
+#[cfg(not(target_os = "windows"))]
Review Comment:
```suggestion
#[cfg(target_family="unix")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org