svn commit: r1780608 - in /maven/plugins/trunk/maven-checkstyle-plugin/src/it: check-tests-only/verify.groovy inlinerules/verify.groovy

[gb...@apache.org]

Author: gboue
Date: Fri Jan 27 20:37:20 2017
New Revision: 1780608

URL: http://svn.apache.org/viewvc?rev=1780608&view=rev
Log:
Improving current ITs, that are testing the failure of the build, by checking what was the actual cause of the failure. This makes sure the build didn't fail for another reason which isn't the one intended.

Added:
    maven/plugins/trunk/maven-checkstyle-plugin/src/it/check-tests-only/verify.groovy   (with props)
Modified:
    maven/plugins/trunk/maven-checkstyle-plugin/src/it/inlinerules/verify.groovy

Added: maven/plugins/trunk/maven-checkstyle-plugin/src/it/check-tests-only/verify.groovy
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/it/check-tests-only/verify.groovy?rev=1780608&view=auto
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/it/check-tests-only/verify.groovy (added)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/it/check-tests-only/verify.groovy Fri Jan 27 20:37:20 2017
@@ -0,0 +1,22 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+def buildLog = new File( basedir, 'build.log' )
+
+assert buildLog.text =~ /There are \d+ errors reported by Checkstyle/

Propchange: maven/plugins/trunk/maven-checkstyle-plugin/src/it/check-tests-only/verify.groovy
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: maven/plugins/trunk/maven-checkstyle-plugin/src/it/check-tests-only/verify.groovy
------------------------------------------------------------------------------
    svn:keywords = Author Date Id Revision

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/it/inlinerules/verify.groovy
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/it/inlinerules/verify.groovy?rev=1780608&r1=1780607&r2=1780608&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/it/inlinerules/verify.groovy (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/it/inlinerules/verify.groovy Fri Jan 27 20:37:20 2017
@@ -20,5 +20,7 @@ assert new File(basedir, 'target/checkst
 assert new File(basedir, 'target/checkstyle-header.txt').exists();
 assert new File(basedir, 'target/checkstyle-result.xml').exists();
 
+def buildLog = new File( basedir, 'build.log' )
+assert buildLog.text =~ /There are \d+ errors reported by Checkstyle/
 
 return true;