You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by fu...@apache.org on 2009/09/16 00:30:19 UTC
svn commit: r815527 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
Author: fuankg
Date: Tue Sep 15 22:30:18 2009
New Revision: 815527
URL: http://svn.apache.org/viewvc?rev=815527&view=rev
Log:
fix compiler brace warning.
Modified:
httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
Modified: httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
URL: http://svn.apache.org/viewvc/httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c?rev=815527&r1=815526&r2=815527&view=diff
==============================================================================
--- httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c (original)
+++ httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c Tue Sep 15 22:30:18 2009
@@ -691,7 +691,7 @@
}
else
/* Special FTPOption that maps NLST directly to LIST */
- if (!is_list && (fsc->options & FTP_OPT_NLSTISLIST) || dashl) {
+ if ((!is_list && (fsc->options & FTP_OPT_NLSTISLIST)) || dashl) {
is_list = 1;
}
Re: svn commit: r815527 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Guenter Knauf wrote:
> sorry, didnt look closely enough, please forgive - fixed with r815577.
No bother :) Not sure it's worth rerolling for, but the other item you
pointed out might be more significant. Looking at it.
Re: svn commit: r815527 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
William A. Rowe, Jr. schrieb:
> Wouldn't this be
>
> if (!is_list && ((fsc->options & FTP_OPT_NLSTISLIST) || dashl)) {
>
> as there is no point otherwise? Actually we could drop the !is_list test,
> considering that forced-override isn't harmful.
sorry, didnt look closely enough, please forgive - fixed with r815577.
Gün.
Re: svn commit: r815527 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
fuankg@apache.org wrote:
> /* Special FTPOption that maps NLST directly to LIST */
> - if (!is_list && (fsc->options & FTP_OPT_NLSTISLIST) || dashl) {
> + if ((!is_list && (fsc->options & FTP_OPT_NLSTISLIST)) || dashl) {
> is_list = 1;
> }
Wouldn't this be
if (!is_list && ((fsc->options & FTP_OPT_NLSTISLIST) || dashl)) {
as there is no point otherwise? Actually we could drop the !is_list test,
considering that forced-override isn't harmful.