[GitHub] [superset] villebro commented on pull request #18246: fix(listview): add nowrap to view mode container

[GitBox <gi...@apache.org>]

villebro commented on pull request #18246:
URL: https://github.com/apache/superset/pull/18246#issuecomment-1026875359


   > @villebro In this case I am not sure if we should do a no-wrap. Those view buttons side by side take up a lot of space and it's even more obvious when you have a few rows of filters. We could actually keep this logic that if there is more than one row the icons are stacked on the top of each other or improve the margins/spacings of the whole component + icons. Wdyt?
   > 
   > The view icon could also be a drop down radio button to save the space.
   
   Thanks @kasiazjc for the review! In the current design, keeping the no-wrap kinda feels ok as the dropdowns usually aren't able to gobble up the whole available space on the right (=the no-wrapped buttons don't eat up valuable horizontal space). However, having said that, I think an alternative layout in the whole component that adjusts to different sizes better would probably be optimal. Did you have a particular layout in mind?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org