You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by tain198127 <gi...@git.apache.org> on 2017/01/12 13:44:25 UTC
[GitHub] incubator-rocketmq pull request #41: 网络环境复杂时，会 成选择...
GitHub user tain198127 opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/41
\u7f51\u7edc\u73af\u5883\u590d\u6742\u65f6\uff0c\u4f1a\u9020\u6210\u9009\u62e9\u4e86\u4e0d\u6b63\u786e\u7684\u7f51\u7edc ip \u5730\u5740\u3002
\u7531\u4e8e clientconfig \u5728\u83b7\u53d6\u672c\u5730 ip \u65f6\uff0cipv4\u83b7\u53d6\u6700\u540e\u4e00\u4e2a ip\uff0c\u81f4\u4f7f\u5728\u53cc\u7f51\u5361\u7684\u73af\u5883\u4e2d\uff0c\u5982\u679c\u6700\u540e\u4e00\u4e2a ip \u5bf9\u5e94\u7684\u662f\u5916\u7f51 ip\u3002\u90a3\u4e48\u53ef\u80fd\u4f1a\u9020\u6210\u6027\u80fd\u4e0b\u964d\u6216\u8005\u65e0\u6cd5\u8054\u901a\u3002\u867d\u7136\u53ef\u4ee5\u4f7f\u7528 setClientIP\u65b9\u6cd5\u6765\u89e3\u51b3\u8fd9\u4e2a\u95ee\u9898\u3002\u4f46\u662f\u5904\u7406\u592a\u8fc7\u786c\u6027\u3002\u5728\u96c6\u7fa4\u73af\u5883\u4e2d\u4f1a\u5bf9\u90e8\u7f72\u9020\u6210\u5f88\u5927\u538b\u529b\u3002
\u4fee\u6539\u589e\u52a0\u4e86\u53ef\u4ee5\u901a\u8fc7\u8fc7\u6ee4\u6765\u53d6\u5f97\u6b63\u786e\u7684\u5730\u5740\u7684\u65b9\u6cd5\u3002
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tain198127/incubator-rocketmq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit 5919c9112ca6cb2a7426ecb9f80121abc39e07ba
Author: tain198127 <ta...@163.com>
Date: 2017-01-12T13:41:14Z
\u7531\u4e8e clientconfig \u5728\u83b7\u53d6\u672c\u5730 ip \u65f6\uff0cipv4\u83b7\u53d6\u6700\u540e\u4e00\u4e2a ip\uff0c\u81f4\u4f7f\u5728\u53cc\u7f51\u5361\u7684\u73af\u5883\u4e2d\uff0c\u5982\u679c\u6700\u540e\u4e00\u4e2a ip \u5bf9\u5e94\u7684\u662f\u5916\u7f51 \u2026
\u2026ip\u3002\u90a3\u4e48\u53ef\u80fd\u4f1a\u9020\u6210\u6027\u80fd\u4e0b\u964d\u6216\u8005\u65e0\u6cd5\u8054\u901a\u3002\u867d\u7136\u53ef\u4ee5\u4f7f\u7528 setClientIP\u65b9\u6cd5\u6765\u89e3\u51b3\u8fd9\u4e2a\u95ee\u9898\u3002\u4f46\u662f\u5904\u7406\u592a\u8fc7\u786c\u6027\u3002\u5728\u96c6\u7fa4\u73af\u5883\u4e2d\u4f1a\u5bf9\u90e8\u7f72\u9020\u6210\u5f88\u5927\u538b\u529b\u3002
\u4fee\u6539\u589e\u52a0\u4e86\u53ef\u4ee5\u901a\u8fc7\u8fc7\u6ee4\u6765\u53d6\u5f97\u6b63\u786e\u7684\u5730\u5740\u7684\u65b9\u6cd5\u3002
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会 成选择了不...
Posted by tain198127 <gi...@git.apache.org>.
Github user tain198127 commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
When the client to start the producer, the producer will use the last one ipv4 address as default ip.but if the os have more than one ipv4 address, it will get some unexpected result.
Although ClientConfig provide a method setClientIP to avoid this issue, but in production environment with cluster ,every producer need to set a ip address, it will make some mistake.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会 成选择了不...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
IMO, this feature is not necessary, clientIP is only used in bornHost.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #41: when the client host have more than 2 i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会 成选择了不...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
Hi @tain198127, could you please use English in the pr title and commit logs?
Also please refer to [here](http://rocketmq.apache.org/docs/code-guidelines/) and [here](http://rocketmq.apache.org/docs/pull-request/) before send a pull request to RocketMQ.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会 成选择了不...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
@tain198127 Could you follow other PR[1] style at first
[1] https://github.com/apache/incubator-rocketmq/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #41: 网络环境复杂时，会 成选择了不...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
Please follow instructs [here](http://rocketmq.incubator.apache.org/docs/pull-request/).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #41: when the client host have more than 2 ip addre...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/41
please follow us PR guide, modify your topic and ensure all testing validity
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---