You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/02 18:37:58 UTC

[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #91: Fix broken GooglePubSubSpec tests

mdedetrich opened a new pull request, #91:
URL: https://github.com/apache/incubator-pekko-connectors/pull/91

   Resolves: https://github.com/apache/incubator-pekko-connectors/issues/47
   
   Turns out the reason why the tests were failing is because at some point an overloaded method with the `host: Option[String]` parameter was added and its this specific overloaded method which is now being called in the auth tests. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #91: Fix broken GooglePubSubSpec tests

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #91:
URL: https://github.com/apache/incubator-pekko-connectors/pull/91#issuecomment-1531972791

   Relevant tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-connectors] mdedetrich merged pull request #91: Fix broken GooglePubSubSpec tests

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #91:
URL: https://github.com/apache/incubator-pekko-connectors/pull/91


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org